You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2025/11/20 14:53:53 UTC
[I] ActorSystem#close now annoying IDEA [pekko]
He-Pin opened a new issue, #2521:
URL: https://github.com/apache/pekko/issues/2521
<img width="719" height="238" alt="Image" src="https://github.com/user-attachments/assets/62a866b9-ccc5-4bbb-9fd2-a34e87f4dc77" />
Now IDEA says I'm not using the `try ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed issue #2521: ActorSystem#close now annoying IDEA
URL: https://github.com/apache/pekko/issues/2521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3559038120
@He-Pin Is it fine to close the issue since we can't do anything about it? We can always re-open it if the status quo changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #2521: ActorSystem#close now annoying IDEA
URL: https://github.com/apache/pekko/issues/2521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3559131223
The only problem is a user may close it because of this IDEA hint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3559525640
I wonder if we could convince them to include ActorSystem in https://github.com/JetBrains/intellij-community/blob/master/java/java-impl/src/com/siyeh/ig/resources/AutoCloseableResourceInspection.java#L48 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3558499182
This is an intellij issue. Nothing we can do about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3559537473
> I wonder if we could convince them to include ActorSystem in https://github.com/JetBrains/intellij-community/blob/master/java/java-impl/src/com/siyeh/ig/resources/AutoCloseableResourceInspection.java#L48 ?
I think that definitely makes sense, do you want to open a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3558587657
Yes, the resource has not been created locally in the block, so that should not be inspected to close with a try resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3581191142
Upstream PR merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3559182004
> The only problem is a user may close it because of this IDEA hint
We can document this in pekko docs, although I am not sure how much of a difference it would make in practice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3560589529
> I wonder if we could convince them to include ActorSystem in https://github.com/JetBrains/intellij-community/blob/master/java/java-impl/src/com/siyeh/ig/resources/AutoCloseableResourceInspection.java#L48 ?
Created a PR at https://github.com/JetBrains/intellij-community/pull/3316, lets see what happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3558495009
Hmm, so IDEA incorrectly infers that it's the responsibility of the caller of `.context().system()` to close the `ActorSystem`? That's rather unfortunate... would there be any way to teach IDEA that this is not the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3558552927
there's a few issues around this at https://youtrack.jetbrains.com/issues?q=%7BAutoCloseable%7D%20project:%20%7BIntelliJ%20IDEA%7D&sort=id&order=desc but I don't see anything we could do about this :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] ActorSystem#close now annoying IDEA [pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #2521:
URL: https://github.com/apache/pekko/issues/2521#issuecomment-3558500059
Yeah I am not sure what to do here, this is an Intellij IDEA issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org