You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Daisuke Miyamoto (JIRA)" <ji...@apache.org> on 2011/03/07 08:21:59 UTC
[jira] Created: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
mahout-math's pom.xml should be configured to compile in Java6
--------------------------------------------------------------
Key: MAHOUT-618
URL: https://issues.apache.org/jira/browse/MAHOUT-618
Project: Mahout
Issue Type: Bug
Components: Math
Reporter: Daisuke Miyamoto
Attachments: mahout-618.patch
Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
{code}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.5</source>
<target>1.5</target>
</configuration>
</plugin>
{code}
Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sean Owen resolved MAHOUT-618.
------------------------------
Resolution: Fixed
Fix Version/s: 0.5
Assignee: Sean Owen
Committed, with a series of related changes, mostly adding @Override for interface methods which is allowed in Java 6.
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003557#comment-13003557 ]
Sean Owen commented on MAHOUT-618:
----------------------------------
Going once going twice -- I'm going to add @Overrides too as part of the change. I hardly think it will break anybody since as you guys note, it actually didn't work with JDK5 to begin with. :)
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Daisuke Miyamoto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daisuke Miyamoto updated MAHOUT-618:
------------------------------------
Attachment: mahout-618.patch
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003282#comment-13003282 ]
Ted Dunning commented on MAHOUT-618:
------------------------------------
Looks like a straightforward fix. My guess is that we didn't see a problem because this got over-ridden by the parent pom and nobody normally compiles math by itself.
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003577#comment-13003577 ]
Ted Dunning commented on MAHOUT-618:
------------------------------------
Over-rides are good!
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004410#comment-13004410 ]
Ted Dunning commented on MAHOUT-618:
------------------------------------
We generally close the ticket when we do the next release.
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Daisuke Miyamoto (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004400#comment-13004400 ]
Daisuke Miyamoto commented on MAHOUT-618:
-----------------------------------------
I appreciate your immediate help.
Who should close this ticket, me or you?
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Assignee: Sean Owen
> Fix For: 0.5
>
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAHOUT-618) mahout-math's pom.xml should be
configured to compile in Java6
Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAHOUT-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003291#comment-13003291 ]
Sean Owen commented on MAHOUT-618:
----------------------------------
We had made mahout-math require only Java 1.5 simply for broader compatibility. It is equally easily possible to remove usages of those offending methods.
However at this stage I am personally comfortable with using Java 6 everywhere simply for consistency. But it's worth asking if anyone really needs 1.5 compatibility?
> mahout-math's pom.xml should be configured to compile in Java6
> --------------------------------------------------------------
>
> Key: MAHOUT-618
> URL: https://issues.apache.org/jira/browse/MAHOUT-618
> Project: Mahout
> Issue Type: Bug
> Components: Math
> Reporter: Daisuke Miyamoto
> Attachments: mahout-618.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> Though Mahout requires JDK6, mahout-math's pom.xml contains plugin configuration which direct compile for Java5 as following:
> {code}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-compiler-plugin</artifactId>
> <configuration>
> <source>1.5</source>
> <target>1.5</target>
> </configuration>
> </plugin>
> {code}
> Furthermore RandomWrapper and DistributionChecks uses String#getBytes(Charset) and Arrays#copyOf() method.
> These methods are not supported in JDK5.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira