You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2023/10/20 18:32:00 UTC

[PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

NihalJain opened a new pull request, #145:
URL: https://github.com/apache/phoenix-omid/pull/145

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1773339031

   Ran following command with a consolidated change of 4 PRs locally:
   mvn clean verify site -Dspotbugs.site -Dhbase.version=2.5.5-hadoop3 -Dsurefire.rerunFailingTestsCount=3 
   PR list:
   - https://github.com/apache/phoenix-omid/pull/143
   - https://github.com/apache/phoenix-omid/pull/144
   - https://github.com/apache/phoenix-omid/pull/145
   - https://github.com/apache/phoenix-omid/pull/146
   
   BUILD was SUCCESS!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779094865

   > Please list the changes in the comit message.
   
   Sure let me add details to commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1791292920

   > @NihalJain could you please handle the conflicts caused due to other merges.
   
   Rebased code. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "chrajeshbabu (via GitHub)" <gi...@apache.org>.
chrajeshbabu merged PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779290106

   Please check the commit message before commit.
   Are the new versions in separate lines ?
   It doesn't look like that me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "chrajeshbabu (via GitHub)" <gi...@apache.org>.
chrajeshbabu commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1787573657

   @NihalJain  could you please handle the conflicts caused due to other merges.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779173881

   Updated commit message, rebased PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#discussion_r1371606112


##########
pom.xml:
##########
@@ -152,21 +152,21 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
         <!-- 3rd-Party Library Versioning -->
-        <hbase.version>2.4.13</hbase.version>
+        <hbase.version>2.4.17</hbase.version>
         <hadoop.version>3.1.4</hadoop.version>
         <phoenix.thirdparty.version>2.0.0</phoenix.thirdparty.version>
         <guice.version>5.1.0</guice.version>
         <testng.version>6.10</testng.version>
         <slf4j.version>1.7.36</slf4j.version>
-        <log4j2.version>2.18.0</log4j2.version>
+        <log4j2.version>2.21.0</log4j2.version>
         <netty4.version>4.1.86.Final</netty4.version>
         <!-- com.google repo will be used except on Aarch64 platform. -->
         <protobuf.group>com.google.protobuf</protobuf.group>
         <protobuf-java.version>2.5.0</protobuf-java.version>
         <protoc.version>2.5.0</protoc.version>
         <protobuf.plugin.version>0.6.1</protobuf.plugin.version>
-        <os.plugin.version>1.6.2</os.plugin.version>
-        <junit.version>4.13.1</junit.version>
+        <os.plugin.version>1.7.1</os.plugin.version>

Review Comment:
   Sure let me update



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OMID-256 Bump hbase and other dependencies to latest version [phoenix-omid]

Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #145:
URL: https://github.com/apache/phoenix-omid/pull/145#discussion_r1371379906


##########
pom.xml:
##########
@@ -152,21 +152,21 @@
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 
         <!-- 3rd-Party Library Versioning -->
-        <hbase.version>2.4.13</hbase.version>
+        <hbase.version>2.4.17</hbase.version>
         <hadoop.version>3.1.4</hadoop.version>
         <phoenix.thirdparty.version>2.0.0</phoenix.thirdparty.version>
         <guice.version>5.1.0</guice.version>
         <testng.version>6.10</testng.version>
         <slf4j.version>1.7.36</slf4j.version>
-        <log4j2.version>2.18.0</log4j2.version>
+        <log4j2.version>2.21.0</log4j2.version>
         <netty4.version>4.1.86.Final</netty4.version>
         <!-- com.google repo will be used except on Aarch64 platform. -->
         <protobuf.group>com.google.protobuf</protobuf.group>
         <protobuf-java.version>2.5.0</protobuf-java.version>
         <protoc.version>2.5.0</protoc.version>
         <protobuf.plugin.version>0.6.1</protobuf.plugin.version>
-        <os.plugin.version>1.6.2</os.plugin.version>
-        <junit.version>4.13.1</junit.version>
+        <os.plugin.version>1.7.1</os.plugin.version>

Review Comment:
   This is a java plugin version.
   I suggest doing this in the maven ticket instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org