You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/01/29 22:04:09 UTC
Review Request 30425: JournalNode failed to restart
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30425/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-9408
https://issues.apache.org/jira/browse/AMBARI-9408
Repository: ambari
Description
-------
The JournalNode dfs.journalnode.* address to use is governed by the dfs_http_policy being either HTTP or HTTPS. It's not governed by the presence of either dfs.journalnode.http-address or dfs.journalnode.https-address which is what this bug is.
Diffs
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py 4e85130
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py b185058
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 79f52ea
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-jmx.json PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json PRE-CREATION
ambari-server/src/test/python/stacks/utils/RMFTestCase.py c19bdb3
Diff: https://reviews.apache.org/r/30425/diff/
Testing
-------
Executed RU...
-----------------------------------------------------------------------
Total run:587
Total errors:2
Total failures:0
ERROR
2 Errors in Knox unrelated to my changes
Thanks,
Jonathan Hurley
Re: Review Request 30425: JournalNode failed to restart
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30425/#review70277
-----------------------------------------------------------
Ship it!
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py
<https://reviews.apache.org/r/30425/#comment115363>
Remove
- Nate Cole
On Jan. 29, 2015, 4:04 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30425/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 4:04 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-9408
> https://issues.apache.org/jira/browse/AMBARI-9408
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The JournalNode dfs.journalnode.* address to use is governed by the dfs_http_policy being either HTTP or HTTPS. It's not governed by the presence of either dfs.journalnode.http-address or dfs.journalnode.https-address which is what this bug is.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py 4e85130
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py b185058
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 79f52ea
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-jmx.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json PRE-CREATION
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py c19bdb3
>
> Diff: https://reviews.apache.org/r/30425/diff/
>
>
> Testing
> -------
>
> Executed RU...
>
>
> -----------------------------------------------------------------------
> Total run:587
> Total errors:2
> Total failures:0
> ERROR
>
> 2 Errors in Knox unrelated to my changes
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 30425: JournalNode failed to restart
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30425/#review70283
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Jan. 29, 2015, 9:40 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30425/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2015, 9:40 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-9408
> https://issues.apache.org/jira/browse/AMBARI-9408
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The JournalNode dfs.journalnode.* address to use is governed by the dfs_http_policy being either HTTP or HTTPS. It's not governed by the presence of either dfs.journalnode.http-address or dfs.journalnode.https-address which is what this bug is.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py 4e85130
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py b185058
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 7f9248b
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 79f52ea
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-jmx.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-namenode-jmx.json PRE-CREATION
> ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json PRE-CREATION
> ambari-server/src/test/python/stacks/utils/RMFTestCase.py c19bdb3
>
> Diff: https://reviews.apache.org/r/30425/diff/
>
>
> Testing
> -------
>
> Executed RU...
>
>
> -----------------------------------------------------------------------
> Total run:587
> Total errors:2
> Total failures:0
> ERROR
>
> 2 Errors in Knox unrelated to my changes
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 30425: JournalNode failed to restart
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30425/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 4:40 p.m.)
Review request for Ambari, Nate Cole and Tom Beerbower.
Changes
-------
-----------------------------------------------------------------------
Total run:588
Total errors:0
Total failures:0
OK
Bugs: AMBARI-9408
https://issues.apache.org/jira/browse/AMBARI-9408
Repository: ambari
Description
-------
The JournalNode dfs.journalnode.* address to use is governed by the dfs_http_policy being either HTTP or HTTPS. It's not governed by the presence of either dfs.journalnode.http-address or dfs.journalnode.https-address which is what this bug is.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode_upgrade.py 4e85130
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params.py b185058
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterDeadlockTest.java 7f9248b
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_journalnode.py 79f52ea
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-hdfs-secure.json PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-jmx.json PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade-namenode-jmx.json PRE-CREATION
ambari-server/src/test/python/stacks/2.2/configs/journalnode-upgrade.json PRE-CREATION
ambari-server/src/test/python/stacks/utils/RMFTestCase.py c19bdb3
Diff: https://reviews.apache.org/r/30425/diff/
Testing
-------
Executed RU...
-----------------------------------------------------------------------
Total run:587
Total errors:2
Total failures:0
ERROR
2 Errors in Knox unrelated to my changes
Thanks,
Jonathan Hurley