[jira] Commented: (NUTCH-944) Increase the number of elements to look for URLs and add the ability to specify multiple attributes by elements

["Julien Nioche (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979530#action_12979530 ] 

Julien Nioche commented on NUTCH-944:
-------------------------------------

Could you please send a patch for 2.0 (trunk) as well? Note that DOMCOntentUtils is used in parse-tika and would also need changing.

Can't we simplify the parsing of the attrsName with string.split(',')? 

A JUnit test would be great (or a modification of the existing one if any)

Thanks fo ryour contribution



> Increase the number of elements to look for URLs and add the ability to specify multiple attributes by elements
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: NUTCH-944
>                 URL: https://issues.apache.org/jira/browse/NUTCH-944
>             Project: Nutch
>          Issue Type: Improvement
>          Components: parser
>    Affects Versions: 1.3
>         Environment: GNU/Linux Fedora 12
>            Reporter: Jean-Francois Gingras
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: DOMContentUtils.java.path-1.0, DOMContentUtils.java.path-1.3
>
>
> Here a patch for DOMContentUtils.java that increase the number of elements to look for URLs. It also add the ability to specify multiple attributes by elements, for example:
> linkParams.put("frame", new LinkParams("frame", "longdesc,src", 0));
> linkParams.put("object", new LinkParams("object", "classid,codebase,data,usemap", 0));
> linkParams.put("video", new LinkParams("video", "poster,src", 0)); // HTML 5
> I have a patch for release-1.0 and branch-1.3
> I would love to hear your comments about this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.