Breaking change in release verifier script

[Zoltán Nagy <ab...@apache.org>]

If you're not using
https://github.com/openzipkin-contrib/apache-release-verification/, feel
free to ignore this.

I've just clicked merge on
https://github.com/openzipkin-contrib/apache-release-verification/pull/15.
This makes the "module" argument optional, and (for consistency) makes the
version argument an option (but a required one). Confused yet? The reason
to do this is so that the verifier script can work on projects with no
"submodules"; for example, in the hierarchy zipkin/brave-karaf, there is
nothing corresponding to "brave-karaf" in Dubbo. It's just dubbo, no slash,
no nothing.

Long story short, instead of ./check.sh brave-karaf 0.1.2, you should now
say ./check.sh --module brave-karaf --version 0.1.2. You can also say
--project zipkin (though that's the default). The README is updated
accordingly.

Re: Breaking change in release verifier script

[Adrian Cole <ad...@gmail.com>]

works for me! thanks for the heads up

On Thu, Apr 4, 2019 at 5:04 PM Zoltán Nagy <ab...@apache.org> wrote:
>
> If you're not using
> https://github.com/openzipkin-contrib/apache-release-verification/, feel
> free to ignore this.
>
> I've just clicked merge on
> https://github.com/openzipkin-contrib/apache-release-verification/pull/15.
> This makes the "module" argument optional, and (for consistency) makes the
> version argument an option (but a required one). Confused yet? The reason
> to do this is so that the verifier script can work on projects with no
> "submodules"; for example, in the hierarchy zipkin/brave-karaf, there is
> nothing corresponding to "brave-karaf" in Dubbo. It's just dubbo, no slash,
> no nothing.
>
> Long story short, instead of ./check.sh brave-karaf 0.1.2, you should now
> say ./check.sh --module brave-karaf --version 0.1.2. You can also say
> --project zipkin (though that's the default). The README is updated
> accordingly.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org