You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/12 07:45:34 UTC

[GitHub] [arrow] vibhatha commented on a diff in pull request #13078: ARROW-15590: [C++] Add support for joins to the Substrait consumer

vibhatha commented on code in PR #13078:
URL: https://github.com/apache/arrow/pull/13078#discussion_r871053424


##########
cpp/src/arrow/engine/substrait/serde_test.cc:
##########
@@ -750,5 +750,309 @@ TEST(Substrait, ExtensionSetFromPlanMissingFunc) {
           &ext_set));
 }
 
+TEST(Substrait, JoinPlanBasic) {

Review Comment:
   Yes, I completely agree with you. One thing we can do is, putting them in a Submodule like the datasets and use it when it is required. But I am not sure how good that option would be. It will again add the same burden of keeping that in the memory (too big), but avoid us keeping the text in the Arrow repo itself. 
   
   Is this feasible? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org