You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/13 06:48:32 UTC

[GitHub] [spark] cloud-fan commented on issue #24469: [SPARK-27576][SQL] table capability to skip the output column resolution

cloud-fan commented on issue #24469: [SPARK-27576][SQL] table capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#issuecomment-491696938
 
 
   Hi @rdblue , I think we need to make an exception now.
   
   https://github.com/apache/spark/pull/24233 removes `SupportsSaveMode`, but it has a hack to bypass the schema check for tables that reports empty schema.
   
   To get rid of that hack, this PR adds a new table capability to bypass the schema check. However, this PR has a hack in `NamedRelation` because the v2 relation is not available in the catalyst.
   
   To remove the hack in this PR, https://github.com/apache/spark/pull/24416 was created to move data source v2 to catalyst. However, #24416 is blocked because `SupportsSaveMode` refers to `SaveMode` which is in sql/core.
   
   I think we need to merge either #24233 or this PR first, even it has a hack. Do you have a better idea?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org