You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "masaori335 (via GitHub)" <gi...@apache.org> on 2025/04/16 05:14:18 UTC
[PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
masaori335 opened a new pull request, #12193:
URL: https://github.com/apache/trafficserver/pull/12193
`HttpCacheSM::pending_action` is used in 3 ways.
1. Read Retry Event
https://github.com/apache/trafficserver/blob/561771b1bad4221631c655d9b443df849b1aeccf/src/proxy/http/HttpCacheSM.cc#L295-L300
2. Action from `cacheProcessor.open_read`
https://github.com/apache/trafficserver/blob/561771b1bad4221631c655d9b443df849b1aeccf/src/proxy/http/HttpCacheSM.cc#L313-L317
3. Action from `cacheProcessor.open_write`
https://github.com/apache/trafficserver/blob/561771b1bad4221631c655d9b443df849b1aeccf/src/proxy/http/HttpCacheSM.cc#L409-L413
This PR decouples the 1. Read Retry Event from others because it schedules an event to `HttpCacheSM` itself, so it's better to track the event by `HttpCacheSM`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2817938390
[approve ci autest 1of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2819888986
[approve ci autest 3of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2817908826
[approve ci autest 3of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2908545778
Good point. It supposed to be acquired. I'll add release assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2817908694
[approve ci autest 0of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2817938084
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2808394030
[approve ci autest 0of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2820026841
[approve ci freebsd]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2909458817
Seems the regression test does not take the lock. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2817935895
[approve ci autest 0of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2940093982
Added to milestone 10.1.0 via #12272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2826661378
Ready for review. The last commit changed how to handle `ACTION_RESULT_DONE` from `CacheProcessor::open_write`. It fixed the AuTest failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 merged PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2820303857
It's pretty interesting, the `txn_box_ramp` AuTest was crashed with an assertion.
```
Fatal: /workspace/src/proxy/http/HttpCacheSM.cc:431: failed assertion `pending_action != nullptr
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2819703911
[approve ci autest 0of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Cleanup: Track HttpCacheSM read retry event [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #12193:
URL: https://github.com/apache/trafficserver/pull/12193#issuecomment-2808394769
[approve ci autest 3of4]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org