You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/27 07:35:10 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #38017: [SPARK-40579][PS] `GroupBy.first` should skip NULLs
zhengruifeng opened a new pull request, #38017:
URL: https://github.com/apache/spark/pull/38017
### What changes were proposed in this pull request?
make `GroupBy.first` skip nulls
### Why are the changes needed?
to fix the behavior difference
```
In [1]:
...: import pandas as pd
...: import numpy as np
...: import pyspark.pandas as ps
...:
...: pdf = pd.DataFrame({"A": [1, 2, 1, 2],"B": [-1.5, np.nan, -3.2, 0.1],})
...: psdf = ps.from_pandas(pdf)
...:
In [2]: pdf.groupby("A").first()
Out[2]:
B
A
1 -1.5
2 0.1
In [3]: psdf.groupby("A").first()
B
A
1 -1.5
2 NaN
```
### Does this PR introduce _any_ user-facing change?
yes, updated `GroupBy.first` will skip NULLs
### How was this patch tested?
added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38017: [SPARK-40579][PS] `GroupBy.first` should skip NULLs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38017: [SPARK-40579][PS] `GroupBy.first` should skip NULLs
URL: https://github.com/apache/spark/pull/38017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38017: [SPARK-40579][PS] `GroupBy.first` should skip NULLs
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38017:
URL: https://github.com/apache/spark/pull/38017#issuecomment-1260274298
Thanks you @HyukjinKwon @dongjoon-hyun @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38017: [SPARK-40579][PS] `GroupBy.first` should skip NULLs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38017:
URL: https://github.com/apache/spark/pull/38017#issuecomment-1260272833
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org