You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2025/04/23 05:56:22 UTC

[PR] fix test [kyuubi]

turboFei opened a new pull request, #7039:
URL: https://github.com/apache/kyuubi/pull/7039

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/master/contributing/code/index.html
     2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug, and what versions are affected.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If a generative AI tooling has been used in the process of authoring this patch, please include
   phrase 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] Fix flaky kubernetes integration test [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2825836421

   ```
   (base) ➜  target grep eventType= unit-tests.log
   07:43:13.820 -1704927850-pool-118-thread-2 INFO KubernetesApplicationAuditLogger: eventType=ADD	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:13.825 -1704927850-pool-117-thread-2 INFO KubernetesApplicationAuditLogger: eventType=ADD	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:13.829 -1704927850-pool-118-thread-1 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:13.840 -1704927850-pool-118-thread-1 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=null, waiting=ContainerStateWaiting(message=null, reason=ContainerCreating, additionalProperties={}), additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:13.840 -1704927850-pool-117-thread-4 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:13.841 -1704927850-pool-117-thread-3 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Pending	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=null, waiting=ContainerStateWaiting(message=null, reason=ContainerCreating, additionalProperties={}), additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=PENDING	appError=''
   07:43:15.257 -1704927850-pool-118-thread-2 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Running	containers=[spark-kubernetes-driver->ContainerState(running=ContainerStateRunning(startedAt=2025-04-23T07:43:14Z, additionalProperties={}), terminated=null, waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=RUNNING	appError=''
   07:43:15.266 -1704927850-pool-117-thread-4 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Running	containers=[spark-kubernetes-driver->ContainerState(running=ContainerStateRunning(startedAt=2025-04-23T07:43:14Z, additionalProperties={}), terminated=null, waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=RUNNING	appError=''
   07:43:23.334 -1704927850-pool-117-thread-4 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Running	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=ContainerStateTerminated(containerID=docker://f19b1e67b63e5d0e73763367a8f0f8ce291b8b05a7776bf6e17ee30d6344e213, exitCode=0, finishedAt=2025-04-23T07:43:22Z, message=null, reason=Completed, signal=null, startedAt=2025-04-23T07:43:14Z, additionalProperties={}), waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=RUNNING	appError=''
   07:43:23.337 -1704927850-pool-118-thread-2 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Running	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=ContainerStateTerminated(containerID=docker://f19b1e67b63e5d0e73763367a8f0f8ce291b8b05a7776bf6e17ee30d6344e213, exitCode=0, finishedAt=2025-04-23T07:43:22Z, message=null, reason=Completed, signal=null, startedAt=2025-04-23T07:43:14Z, additionalProperties={}), waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=RUNNING	appError=''
   07:43:24.378 -1704927850-pool-118-thread-1 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=null	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Succeeded   	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=ContainerStateTerminated(containerID=docker://f19b1e67b63e5d0e73763367a8f0f8ce291b8b05a7776bf6e17ee30d6344e213, exitCode=0, finishedAt=2025-04-23T07:43:22Z, message=null, reason=Completed, signal=null, startedAt=2025-04-23T07:43:14Z, additionalProperties={}), waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=FINISHED	appError=''
   07:43:24.379 -1704927850-pool-117-thread-3 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=13496573-9b18-4a25-b919-2b8f0c3fc1f5	context=minikube	namespace=null	pod=kyuubi-spark-driver-1745394188472	podState=Succeeded	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=ContainerStateTerminated(containerID=docker://f19b1e67b63e5d0e73763367a8f0f8ce291b8b05a7776bf6e17ee30d6344e213, exitCode=0, finishedAt=2025-04-23T07:43:22Z, message=null, reason=Completed, signal=null, startedAt=2025-04-23T07:43:14Z, additionalProperties={}), waiting=null, additionalProperties={})]	appId=spark-57718fe22cdf4ea1a8c59c37b84c4365	appName=spark-pi	appState=FINISHED	appError=''
   07:46:14.726 -1704927850-pool-117-thread-6 INFO KubernetesApplicationAuditLogger: eventType=ADD	label=4ff66d56-ce78-477f-b51c-34902112bc06	context=minikube	namespace=null	pod=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34902112bc06-driver	podState=Pending	containers=[]	appId=spark-bf31068709f241539e413038c05ed49a	appName=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34	appState=PENDINGappError=''
   07:46:14.738 -1704927850-pool-117-thread-5 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=4ff66d56-ce78-477f-b51c-34902112bc06	context=minikube	namespace=null	pod=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34902112bc06-driver	podState=Pending	containers=[]	appId=spark-bf31068709f241539e413038c05ed49a	appName=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34	appState=PENDING	appError=''
   07:46:14.752 -1704927850-pool-117-thread-6 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=4ff66d56-ce78-477f-b51c-34902112bc06	context=minikube	namespace=null	pod=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34902112bc06-driver	podState=Pending	containers=[spark-kubernetes-driver->ContainerState(running=null, terminated=null, waiting=ContainerStateWaiting(message=null, reason=ContainerCreating, additionalProperties={}), additionalProperties={})]	appId=spark-bf31068709f241539e413038c05ed49a	appName=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34	appState=PENDING	appError=''
   07:46:16.088 -1704927850-pool-117-thread-6 INFO KubernetesApplicationAuditLogger: eventType=UPDATE	label=4ff66d56-ce78-477f-b51c-34902112bc06	context=minikube	namespace=null	pod=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34902112bc06-driver	podState=Running	containers=[spark-kubernetes-driver->ContainerState(running=ContainerStateRunning(startedAt=2025-04-23T07:46:15Z, additionalProperties={}), terminated=null, waiting=null, additionalProperties={})]	appId=spark-bf31068709f241539e413038c05ed49a	appName=kyuubi-user-spark-sql-runner-default-4ff66d56-ce78-477f-b51c-34	appState=RUNNING	appError=''
   (base) ➜  target
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] Fix flaky kubernetes integration test [kyuubi]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2823307204

   ## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/7039?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 0.00%. Comparing base [(`f0c31e2`)](https://app.codecov.io/gh/apache/kyuubi/commit/f0c31e2f78d991f9b36329499e48db54ff8a5a5a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`25d16a6`)](https://app.codecov.io/gh/apache/kyuubi/commit/25d16a68718bfd1a81b1cde47ed12b4c1b1ad3ee?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@          Coverage Diff           @@
   ##           master   #7039   +/-   ##
   ======================================
     Coverage    0.00%   0.00%           
   ======================================
     Files         695     695           
     Lines       42816   42816           
     Branches     5830    5830           
   ======================================
     Misses      42816   42816           
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/7039?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#discussion_r2059569496


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -466,12 +473,11 @@ class KubernetesApplicationOperation extends ApplicationOperation with Logging {
       podLabelUniqueKey: String): Unit = {
     try {
       val kubernetesClient = getOrCreateKubernetesClient(kubernetesInfo)
-      val deleted = if (podName == null) {
-        !kubernetesClient.pods()
-          .withLabel(LABEL_KYUUBI_UNIQUE_KEY, podLabelUniqueKey)
-          .delete().isEmpty
-      } else {
-        !kubernetesClient.pods().withName(podName).delete().isEmpty
+      val deleted = Option(podName) match {

Review Comment:
   No functionality change? TBH, I prefer the original style.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#discussion_r2059495155


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ApplicationOperation.scala:
##########
@@ -129,6 +129,33 @@ object ApplicationInfo {
   val UNKNOWN: ApplicationInfo = ApplicationInfo(null, null, ApplicationState.UNKNOWN)
 }
 
+class KubernetesApplicationInfo(
+    id: String,
+    name: String,
+    state: ApplicationState,
+    url: Option[String] = None,
+    error: Option[String] = None,
+    val podName: String) extends ApplicationInfo(id, name, state, url, error) {

Review Comment:
   extending case class is tricky, seems that we can simply add a field podName: `Option[String]` to `ApplicationInfo`, and leave a comment: only used for K8s, even for K8s cases, still possible to be None for cases like NOT_FOUND state



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2829392482

   LGTM, only a nit about style


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2829425283

   thanks, merged to main and 1.10.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] Fix flaky kubernetes integration test [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2825841125

   ```
   07:43:24.443 KyuubiSessionManager-exec-pool: Thread-583 INFO OperationAuditLogger: operation=093505d1-74ab-4f2b-8994-7fd5f4e1f9da	opType=BatchJobSubmission	state=FINISHED	user=runner	session=13496573-9b18-4a25-b919-2b8f0c3fc1f5
   07:46:08.577 ScalaTest-main-running-KyuubiOperationKubernetesClusterClusterModeSuite INFO KyuubiOperationKubernetesClusterClusterModeSuite: 
   
   ===== FINISHED o.a.k.kubernetes.test.spark.KyuubiOperationKubernetesClusterClusterModeSuite: 'Spark Cluster Mode On Kubernetes Kyuubi KubernetesApplicationOperation Suite' =====
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#discussion_r2059514653


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ApplicationOperation.scala:
##########
@@ -129,6 +129,33 @@ object ApplicationInfo {
   val UNKNOWN: ApplicationInfo = ApplicationInfo(null, null, ApplicationState.UNKNOWN)
 }
 
+class KubernetesApplicationInfo(
+    id: String,
+    name: String,
+    state: ApplicationState,
+    url: Option[String] = None,
+    error: Option[String] = None,
+    val podName: String) extends ApplicationInfo(id, name, state, url, error) {

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#issuecomment-2829423891

   The spark k8s IT has passed, merging to fix the GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #7039: [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name
URL: https://github.com/apache/kyuubi/pull/7039


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


Re: [PR] [KYUUBI #7034][FOLLOWUP] Decouple the kubernetes pod name and app name [kyuubi]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #7039:
URL: https://github.com/apache/kyuubi/pull/7039#discussion_r2059570335


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -466,12 +473,11 @@ class KubernetesApplicationOperation extends ApplicationOperation with Logging {
       podLabelUniqueKey: String): Unit = {
     try {
       val kubernetesClient = getOrCreateKubernetesClient(kubernetesInfo)
-      val deleted = if (podName == null) {
-        !kubernetesClient.pods()
-          .withLabel(LABEL_KYUUBI_UNIQUE_KEY, podLabelUniqueKey)
-          .delete().isEmpty
-      } else {
-        !kubernetesClient.pods().withName(podName).delete().isEmpty
+      val deleted = Option(podName) match {

Review Comment:
   reverted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org