[hbase] branch branch-2.4 updated: HBASE-26105 Rectify the expired TODO comment in CombinedBC. (#3509)

[zh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

zhangduo pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.4 by this push:
     new cb1174e  HBASE-26105 Rectify the expired TODO comment in CombinedBC. (#3509)
cb1174e is described below

commit cb1174e9e124339b647ae9537eca04af5d5b51b2
Author: YutSean <yu...@gmail.com>
AuthorDate: Fri Jul 30 21:34:14 2021 +0800

    HBASE-26105 Rectify the expired TODO comment in CombinedBC. (#3509)
    
    Signed-off-by: Duo Zhang <zh...@apache.org>
---
 .../main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java  | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
index d3f2a73..5c3038e 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CombinedBlockCache.java
@@ -74,8 +74,6 @@ public class CombinedBlockCache implements ResizableBlockCache, HeapSize {
   @Override
   public Cacheable getBlock(BlockCacheKey cacheKey, boolean caching,
       boolean repeat, boolean updateCacheMetrics) {
-    // TODO: is there a hole here, or just awkwardness since in the lruCache getBlock
-    // we end up calling l2Cache.getBlock.
     // We are not in a position to exactly look at LRU cache or BC as BlockType may not be getting
     // passed always.
     boolean existInL1 = l1Cache.containsBlock(cacheKey);