You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "arosien (via GitHub)" <gi...@apache.org> on 2023/05/09 04:56:51 UTC
[GitHub] [daffodil-vscode] arosien commented on a diff in pull request #620: Launch wizard updates and rename data editor vars
arosien commented on code in PR #620:
URL: https://github.com/apache/daffodil-vscode/pull/620#discussion_r1188123845
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
Review Comment:
```suggestion
"dataEditor": {
```
`Config` seems redundant.
##########
package.json:
##########
@@ -413,27 +413,14 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
- "type": "integer",
- "description": "Editor server default port",
- "default": 9000
- },
- "dataEditor.logFile": {
- "type": "string",
- "description": "Path to log file for data editor",
- "default": "${workspaceFolder}/dataEditor-${omegaEditPort}.log"
- },
- "dataEditor.logLevel": {
- "type": "string",
- "description": "Log level for data editor",
- "enum": [
- "error",
- "warn",
- "info",
- "debug",
- "trace"
- ],
- "default": "info"
+ "dataEditorConfig": {
+ "type": "object",
+ "description": "Configuration for Data Editor. Settings are omegaEditPort, logFile and logLevel",
+ "default": {
+ "omegaEditPort": 9000,
Review Comment:
```suggestion
"port": 9000,
```
Maybe just `port`?
##########
package.json:
##########
@@ -627,17 +618,17 @@
},
"default": {}
},
- "dataEditor.omegaEditPort": {
+ "dataEditorOmegaEditPort": {
Review Comment:
I'm unsure what the schema definitions in this `configuration` section are for. They aren't official sections listed under https://code.visualstudio.com/api/extension-guides/debugger-extension#anatomy-of-the-package.json-of-a-debugger-extension.
Looking around, it seems to be a custom configuration section we use to provide default values(?). If so, it can probably be removed and the `contributes/debuggers/configurationAttributes` section can be the sole location of launch schema and defaults.
This should probably be a different ticket for a different release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org