You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/21 07:11:20 UTC
[GitHub] [shardingsphere-elasticjob] gzdzss opened a new pull request #1218: Add test case for BootstrapEnvironment.getMesosRole and getFrameworkHostPort
gzdzss opened a new pull request #1218:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1218
Fixes #1209 .
Changes proposed in this pull request:
Add test case for BootstrapEnvironment.getMesosRole and getFrameworkHostPort
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1218: Add test case for BootstrapEnvironment.getMesosRole and getFrameworkHostPort
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1218:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1218: Add test case for BootstrapEnvironment.getMesosRole and getFrameworkHostPort
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1218:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1218#discussion_r458214473
##########
File path: elasticjob-cloud/elasticjob-cloud-scheduler/src/test/java/org/apache/shardingsphere/elasticjob/cloud/scheduler/env/BootstrapEnvironmentTest.java
##########
@@ -111,4 +111,19 @@ public void assertReconcileConfiguration() {
assertThat(configuration.getReconcileIntervalMinutes(), is(0));
assertFalse(configuration.isEnabledReconcile());
}
+
+ @Test
+ public void assertGetMesosRole() {
+ assertThat(bootstrapEnvironment.getMesosRole(), is(Optional.empty()));
+ Properties properties = new Properties();
+ properties.setProperty(BootstrapEnvironment.EnvironmentArgument.MESOS_ROLE.getKey(), "0");
+ ReflectionUtils.setFieldValue(bootstrapEnvironment, "properties", properties);
Review comment:
The code add `ReflectionUtils`, but now import, is it cause compile failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org