You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2017/07/06 20:56:39 UTC
svn commit: r1801109 -
/tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml
Author: markt
Date: Thu Jul 6 20:56:39 2017
New Revision: 1801109
URL: http://svn.apache.org/viewvc?rev=1801109&view=rev
Log:
FindBugs: More false positives
Modified:
tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml?rev=1801109&r1=1801108&r2=1801109&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/tc7.0.x/trunk/res/findbugs/filter-false-positives.xml Thu Jul 6 20:56:39 2017
@@ -142,6 +142,12 @@
<Bug code="SWL" />
</Match>
<Match>
+ <!-- null return value is documented -->
+ <Class name="org.apache.catalina.core.StandardWrapper" />
+ <Method name="isSingleThreadModel" />
+ <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
+ </Match>
+ <Match>
<!-- The code is adding HTTP request headers, not parameters and the
header parsing on input will have removed any CR or LF characters. -->
<Class name="org.apache.catalina.filters.CorsFilter" />
@@ -472,6 +478,22 @@
<Bug code="RV" />
</Match>
<Match>
+ <!-- Use of == is deliberate -->
+ <Class name="org.apache.tomcat.jdbc.pool.JdbcInterceptor" />
+ <Method name="compare" />
+ <Bug code="ES" />
+ </Match>
+ <Match>
+ <!-- Lack of thread-safety is accepted in return for better performance. -->
+ <Class name="org.apache.tomcat.jdbc.pool.interceptor.SlowQueryReport$QueryStats" />
+ <Or>
+ <Method name="add" />
+ <Method name="failure" />
+ <Method name="prepare" />
+ </Or>
+ <Bug code="VO" />
+ </Match>
+ <Match>
<Class name="org.apache.tomcat.util.IntrospectionUtils" />
<Method name="findMethod"/>
<Bug code="NP" />
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org