You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 16:12:02 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9144: Add link to Swagger UI to navbar
mik-laj opened a new pull request #9144:
URL: https://github.com/apache/airflow/pull/9144
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435401602
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
+ category="Docs")
Review comment:
This is a tab in the menu. We already have WWW and other resources in this tab, so it's okay for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435396186
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
+ category="Docs")
Review comment:
```suggestion
category="API Docs")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435404795
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
Review comment:
aah I thought it was a typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #9144:
URL: https://github.com/apache/airflow/pull/9144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435404547
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
+ category="Docs")
Review comment:
oh yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435395965
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
Review comment:
```suggestion
href='/api/v1/api/v1_swagger_ui_index',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435404097
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
+ category="Docs")
Review comment:
I added screenshot to the description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435402024
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
Review comment:
It's required. We need to refer to an endpoint that is in another blueprint. To do this, we must use the syntax "{blueprint_name}.{endpoint_name}". These two names are generated by connexion, so we have no influence that it do not look cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435402024
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
Review comment:
It's required. We need to refer to an endpoint that is in another blueprint. To do this, we must use the syntax `{blueprint_name}.{endpoint_name}`. These two names are generated by connexion, so we have no influence that it do not look cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9144: Add link to Swagger UI to navbar
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9144:
URL: https://github.com/apache/airflow/pull/9144#discussion_r435405868
##########
File path: airflow/www/app.py
##########
@@ -200,6 +200,9 @@ def init_views(appbuilder):
appbuilder.add_link("GitHub",
href='https://github.com/apache/airflow',
category="Docs")
+ appbuilder.add_link("REST API Reference",
+ href='/api/v1./api/v1_swagger_ui_index',
Review comment:
It took me some time to find out these names, but I added a test to detect if something went wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org