You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "spetz (via GitHub)" <gi...@apache.org> on 2026/08/27 13:18:26 UTC
[PR] fix(cluster): prevent repaired prepares from rewinding WAL parent [iggy]
spetz opened a new pull request, #3978:
URL: https://github.com/apache/iggy/pull/3978
Metadata repair could backfill an operation below the sequencer
frontier and still replace the checksum used to parent the next
prepare. A promoted replica then wrote a higher operation whose
parent skipped committed WAL entries. Recovery correctly rejected
the interior chain break and refused to truncate a suffix that
can hold committed operations, leaving every node that durably
held the bad entry unable to restart.
Resolve the repaired frontier in one place: walk the contiguous
journal above the current head and update the sequencer and
last_prepare_checksum together or not at all. Lower backfill
yields no update. Gap closure reads the checksum from the journal
header at the new head, so the frame that happened to close the
gap cannot stamp its own checksum as the parent. The helper lives
in consensus and both repair ingest paths use it. The partition
path carried the same pattern, inert only while partition prepare
checksums are structurally zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(cluster): prevent repaired prepares from rewinding WAL parent [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3978:
URL: https://github.com/apache/iggy/pull/3978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(cluster): prevent repaired prepares from rewinding WAL parent [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3978:
URL: https://github.com/apache/iggy/pull/3978#issuecomment-5440779999
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3978?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 82.43%. Comparing base ([`9c6451d`](https://app.codecov.io/gh/apache/iggy/commit/9c6451d62f483dea8ebb4c8e08f0c91ecde8e6f2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f78146c`](https://app.codecov.io/gh/apache/iggy/commit/f78146c2d34c10e779618511924461d2f9deb0a1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3978 +/- ##
============================================
- Coverage 84.20% 82.43% -1.77%
Complexity 1398 1398
============================================
Files 1219 1219
Lines 173642 173621 -21
Branches 140740 140721 -19
============================================
- Hits 146208 143120 -3088
- Misses 23468 26695 +3227
+ Partials 3966 3806 -160
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.00% <ø> (-0.01%)` | :arrow_down: |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.23% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.18% <ø> (-26.21%)` | :arrow_down: |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.06% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `85.65% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `96.07% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3978/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.58% <ø> (-13.52%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3978?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/consensus/src/plane\_helpers.rs](https://app.codecov.io/gh/apache/iggy/pull/3978?src=pr&el=tree&filepath=core%2Fconsensus%2Fsrc%2Fplane_helpers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb25zZW5zdXMvc3JjL3BsYW5lX2hlbHBlcnMucnM=) | `94.45% <ø> (ø)` | |
| [core/journal/src/prepare\_journal.rs](https://app.codecov.io/gh/apache/iggy/pull/3978?src=pr&el=tree&filepath=core%2Fjournal%2Fsrc%2Fprepare_journal.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9qb3VybmFsL3NyYy9wcmVwYXJlX2pvdXJuYWwucnM=) | `90.61% <ø> (ø)` | |
| [core/partitions/src/iggy\_partition.rs](https://app.codecov.io/gh/apache/iggy/pull/3978?src=pr&el=tree&filepath=core%2Fpartitions%2Fsrc%2Figgy_partition.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9wYXJ0aXRpb25zL3NyYy9pZ2d5X3BhcnRpdGlvbi5ycw==) | `87.11% <ø> (-0.04%)` | :arrow_down: |
| [core/shard/src/lib.rs](https://app.codecov.io/gh/apache/iggy/pull/3978?src=pr&el=tree&filepath=core%2Fshard%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zaGFyZC9zcmMvbGliLnJz) | `81.16% <ø> (-0.03%)` | :arrow_down: |
... and [96 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3978/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org