You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/23 21:01:36 UTC
[GitHub] [iceberg] Fokko opened a new pull request, #4844: Add build and release instructions
Fokko opened a new pull request, #4844:
URL: https://github.com/apache/iceberg/pull/4844
- Moving to poetry as well for releasing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#issuecomment-1147447219
@rdblue It is actually part of Intellij now 🥳
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#discussion_r884334040
##########
python/README.md:
##########
@@ -30,26 +30,27 @@ cd iceberg/python
pip install -e .
```
-## Testing
+Development is made easy using [Poetry](https://python-poetry.org/docs/#installation).
-Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project.
+## Development
Review Comment:
I also had to upgrade pip and virtualenv in Ubuntu 20.04 to get poetry working properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
rdblue merged PR #4844:
URL: https://github.com/apache/iceberg/pull/4844
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#discussion_r884333473
##########
python/README.md:
##########
@@ -30,26 +30,27 @@ cd iceberg/python
pip install -e .
```
-## Testing
+Development is made easy using [Poetry](https://python-poetry.org/docs/#installation).
-Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project.
+## Development
Review Comment:
It would be good to have a setup section that instructs you to run `pip install poetry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on a diff in pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
Fokko commented on code in PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#discussion_r886963843
##########
python/README.md:
##########
@@ -30,26 +30,27 @@ cd iceberg/python
pip install -e .
```
-## Testing
+Development is made easy using [Poetry](https://python-poetry.org/docs/#installation).
-Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project.
+## Development
Review Comment:
Cool, I've added the commands 👍🏻 btw, some interesting combinations you have there. `sudo` shouldn't be required, and `pip install` and `python3 -m pip install` are equivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko commented on pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
Fokko commented on PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#issuecomment-1143780561
Hey @rdblue thanks for giving this a try. Unfortunately, the IDEA plugin seems to be outdated; https://plugins.jetbrains.com/plugin/14307-poetry/versions Only available for <= 2021 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#issuecomment-1140526714
This looks good to me, but I'd love to hear what other python people think about moving to poetry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #4844: Add Poetry build and release instructions
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #4844:
URL: https://github.com/apache/iceberg/pull/4844#discussion_r884334084
##########
python/README.md:
##########
@@ -30,26 +30,27 @@ cd iceberg/python
pip install -e .
```
-## Testing
+Development is made easy using [Poetry](https://python-poetry.org/docs/#installation).
-Testing is done using tox. The config can be found in `tox.ini` within the python directory of the iceberg project.
+## Development
Review Comment:
`sudo pip install virtualenv --upgrade` and `sudo python3 -m pip install --upgrade pip`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org