[jira] [Resolved] (SOLR-14819) SOLR has linear log operations that could trivially be linear

["Bruno Roustant (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bruno Roustant resolved SOLR-14819.
-----------------------------------
    Fix Version/s: 8.7
       Resolution: Fixed

Thanks Thomas for this fix.

Please share the info about this detection tool in Lucene/Solr dev list ([https://lucene.apache.org/solr/community.html#mailing-lists-irc]) for a wider audience and discussion.

Personally I find the report verbose, so I wonder how verbose it would be on a specific Jira issue. Clearly the difficulty is to avoid too much false detections.

> SOLR has linear log operations that could trivially be linear
> -------------------------------------------------------------
>
>                 Key: SOLR-14819
>                 URL: https://issues.apache.org/jira/browse/SOLR-14819
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Thomas DuBuisson
>            Priority: Trivial
>             Fix For: 8.7
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> The SOLR code has a few linear log operations that could be linear.  That is, operations of
>  
> ```
> for(key in hashmap) doThing(hashmap.get(key));
>  
> ```
>  
> vs just `for(value in hashmap) doThing(value)`
>  
> I have a PR incoming on GitHub to fix a couple of these issue as [found by Infer on Muse|https://console.muse.dev/result/TomMD/lucene-solr/01EH5WXS6C1RH1NFYHP6ATXTZ9?search=JsonSchemaValidator&tab=results].
>     



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org