You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Xinihiko (via GitHub)" <gi...@apache.org> on 2025/03/24 18:58:15 UTC
[PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Xinihiko opened a new pull request, #50372:
URL: https://github.com/apache/spark/pull/50372
Changes made to support the changes in setuptools 78.0.1 which enforce the usage of underscore (`_`) instead of dash (`-`)
### What changes were proposed in this pull request?
Change `description-file` to `description_file` in `setup.cfg`
### Why are the changes needed?
This is related to https://github.com/pypa/setuptools/pull/4870 - in which caused multiple CI error that caused by the underscore enforcement (WARN to RAISE ERROR)
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
No
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50372:
URL: https://github.com/apache/spark/pull/50372#issuecomment-2750700960
3.4 is EOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "Xinihiko (via GitHub)" <gi...@apache.org>.
Xinihiko commented on PR #50372:
URL: https://github.com/apache/spark/pull/50372#issuecomment-2749830919
Hi @bjornjorgensen,
I want to make sure that this means 3.4 is not supported right?
The only supported should be 3.5 and 4.0?
And if it not supported anymore, I'll close the PR
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #50372:
URL: https://github.com/apache/spark/pull/50372#issuecomment-2749149776
I will soon do it for branch 3.4.. waiting for branch 3.5 to finish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #50372:
URL: https://github.com/apache/spark/pull/50372#issuecomment-2749495467
_4) Spark 3.4.4: Released on October 27, 2024. This will be the final maintenance release for the 3.4 series._ from Matei's ASF board report draft for November 2024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "bjornjorgensen (via GitHub)" <gi...@apache.org>.
bjornjorgensen commented on PR #50372:
URL: https://github.com/apache/spark/pull/50372#issuecomment-2750675656
Yes, the only supported now is 3.5 and 4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #50372: [Pyspark 3.4][SPARK-45994][PYTHON] Change description-file to description_file
URL: https://github.com/apache/spark/pull/50372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org