[GitHub] [tinkerpop] lyndonb-bq commented on a change in pull request #1515: TINKERPOP-2555 - Remote Transaction Support (g.tx()) for gremlin-python

[GitBox <gi...@apache.org>]

lyndonb-bq commented on a change in pull request #1515:
URL: https://github.com/apache/tinkerpop/pull/1515#discussion_r766212696



##########
File path: gremlin-python/src/main/python/gremlin_python/driver/client.py
##########
@@ -129,24 +123,28 @@ def _get_connection(self):
             headers=self._headers)
 
     def submit(self, message, bindings=None, request_options=None):
-        return self.submitAsync(message, bindings=bindings, request_options=request_options).result()
+        return self.submit_async(message, bindings=bindings, request_options=request_options).result()
 
-    def submitAsync(self, message, bindings=None, request_options=None):

Review comment:
       That is a good point, I will do the warning / DeprecationWarning thing noted above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org