You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/05/05 18:15:35 UTC
Review Request 33851: Prepare oozie war should check for secure.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33851/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-10936
https://issues.apache.org/jira/browse/AMBARI-10936
Repository: ambari
Description
-------
Restarting oozie server re-generates the oozie web app war. This is not a problem unless the war has been manually generated with the -secure flag (in the case of https).
Ambari should generate the war with the -secure flag as appropriate based on config which will drive the war creation.
Whether you need prepare-war –secure or not can be directly inferred from the oozie base url. If the scheme is https then you need –secure else not.
Diffs
-----
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 77b3cdc
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c4a62ea
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 4be8a50
ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py c706ee7
ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3faf7a1
Diff: https://reviews.apache.org/r/33851/diff/
Testing
-------
Manual test Oozie service install/start with oozie-site/oozie.base.url http and https.
Update unit tests for secure.
All tests pass.
Thanks,
Tom Beerbower
Re: Review Request 33851: Prepare oozie war should check for secure.
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On May 5, 2015, 7:23 p.m., Nate Cole wrote:
> > Looks good - I'm assuming that either the config is moved automatically or the user has to set it somewhere?
Thanks for the review. Yeah, next release we will have an option in Ambari to make it easier to setup https for a cluster but for now they have to set the config manually. Checking the oozie base url is what the Oozie guys suggested for now.
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33851/#review82564
-----------------------------------------------------------
On May 5, 2015, 4:15 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33851/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 4:15 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-10936
> https://issues.apache.org/jira/browse/AMBARI-10936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Restarting oozie server re-generates the oozie web app war. This is not a problem unless the war has been manually generated with the -secure flag (in the case of https).
> Ambari should generate the war with the -secure flag as appropriate based on config which will drive the war creation.
> Whether you need prepare-war –secure or not can be directly inferred from the oozie base url. If the scheme is https then you need –secure else not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 77b3cdc
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c4a62ea
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 4be8a50
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py c706ee7
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3faf7a1
>
> Diff: https://reviews.apache.org/r/33851/diff/
>
>
> Testing
> -------
>
> Manual test Oozie service install/start with oozie-site/oozie.base.url http and https.
>
> Update unit tests for secure.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 33851: Prepare oozie war should check for secure.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33851/#review82564
-----------------------------------------------------------
Ship it!
Looks good - I'm assuming that either the config is moved automatically or the user has to set it somewhere?
- Nate Cole
On May 5, 2015, 12:15 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33851/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 12:15 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-10936
> https://issues.apache.org/jira/browse/AMBARI-10936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Restarting oozie server re-generates the oozie web app war. This is not a problem unless the war has been manually generated with the -secure flag (in the case of https).
> Ambari should generate the war with the -secure flag as appropriate based on config which will drive the war creation.
> Whether you need prepare-war –secure or not can be directly inferred from the oozie base url. If the scheme is https then you need –secure else not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 77b3cdc
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c4a62ea
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 4be8a50
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py c706ee7
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3faf7a1
>
> Diff: https://reviews.apache.org/r/33851/diff/
>
>
> Testing
> -------
>
> Manual test Oozie service install/start with oozie-site/oozie.base.url http and https.
>
> Update unit tests for secure.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 33851: Prepare oozie war should check for secure.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33851/#review82572
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On May 5, 2015, 12:15 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33851/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 12:15 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-10936
> https://issues.apache.org/jira/browse/AMBARI-10936
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Restarting oozie server re-generates the oozie web app war. This is not a problem unless the war has been manually generated with the -secure flag (in the case of https).
> Ambari should generate the war with the -secure flag as appropriate based on config which will drive the war creation.
> Whether you need prepare-war –secure or not can be directly inferred from the oozie base url. If the scheme is https then you need –secure else not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py 77b3cdc
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py c4a62ea
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py 4be8a50
> ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py c706ee7
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 3faf7a1
>
> Diff: https://reviews.apache.org/r/33851/diff/
>
>
> Testing
> -------
>
> Manual test Oozie service install/start with oozie-site/oozie.base.url http and https.
>
> Update unit tests for secure.
>
> All tests pass.
>
>
> Thanks,
>
> Tom Beerbower
>
>