You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/01/23 23:43:34 UTC
[jira] [Commented] (LIBCLOUD-657) Update Google auth to support new
JSON key format
[ https://issues.apache.org/jira/browse/LIBCLOUD-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290154#comment-14290154 ]
ASF GitHub Bot commented on LIBCLOUD-657:
-----------------------------------------
GitHub user erjohnso opened a pull request:
https://github.com/apache/libcloud/pull/438
[google compute] LIBCLOUD-657 add support for JSON private key format
Google has introduced a new JSON formatted private key for Service Accounts. This PR adds support for the new format along with some improved handling of files vs strings for the key value. Docs have been updated to inform users Google prefers the JSON format versus legacy P12 format.
/cc @windo - This PR also includes the patch from Siim Poder via [LIBCLOUD-627](https://issues.apache.org/jira/browse/LIBCLOUD-627) to fix auth with Python 3.
Manual testing was done for the various file formats and using Python 2.7 and 3.2.
/cc @carlcrott since I broke you last time I touched GCE auth and if I do it again, he'll give me a :facepunch:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/erjohnso/libcloud LIBCLOUD-657_google_json_auth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #438
----
commit bca920d19282c12eb60f0e71e87dfeab1e4b1607
Author: Eric Johnson <er...@google.com>
Date: 2015-01-23T22:32:26Z
[google compute] add support for JSON private key format
----
> Update Google auth to support new JSON key format
> -------------------------------------------------
>
> Key: LIBCLOUD-657
> URL: https://issues.apache.org/jira/browse/LIBCLOUD-657
> Project: Libcloud
> Issue Type: New Feature
> Components: Compute
> Reporter: Eric Johnson
> Assignee: Eric Johnson
>
> Google introduced a new Service Account key format (JSON) and over time this will likely become the preferred format. We should begin by supporting this new format soon. If Google does make this the default, we may want to follow-up and issue a (debug | info) warning to users relying on P12 format.
> AFAIK, there is no clear documentation on this format. However, if you open up the Developers Console and look under "APIs & Auth" -> "Credentials", you'll see the "Generate New JSON Key" button next to any existing Service Accounts (or be given the option to create one with a new SA).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)