You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Henning Schmiedehausen (JIRA)" <ji...@apache.org> on 2009/01/14 00:24:59 UTC

[jira] Created: (SHINDIG-848) core.io/io.js does not look at the return code from the request

core.io/io.js does not look at the return code from the request
---------------------------------------------------------------

                 Key: SHINDIG-848
                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
             Project: Shindig
          Issue Type: Bug
          Components: Features (Javascript)
    Affects Versions: trunk, 1.0.x-incubating
            Reporter: Henning Schmiedehausen
         Attachments: SHINDIG-848.patch

While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Louis Ryan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Louis Ryan reopened SHINDIG-848:
--------------------------------


Reverting the commit for a couple of reasons.
- It broke the js unit tests.
- Im pretty sure the behavior isnt correct and needs further review. Its perfectly fine to have non-200 responses with valid feed/json content

> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: trunk, 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>            Assignee: Vincent Siveton
>             Fix For: trunk, 1.0.x-incubating
>
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton updated SHINDIG-848:
------------------------------------

    Assignee:     (was: Vincent Siveton)

> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: trunk, 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>             Fix For: trunk, 1.0.x-incubating
>
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner updated SHINDIG-848:
---------------------------------

    Affects Version/s:     (was: 1.0.x-incubating)
        Fix Version/s:     (was: 1.0.x-incubating)

bumping to 1.1

> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: trunk
>            Reporter: Henning Schmiedehausen
>             Fix For: trunk
>
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-848.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1-BETA5

latest core.io has much better error reporting.


> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 1.1-BETA1
>            Reporter: Henning Schmiedehausen
>             Fix For: 1.1-BETA5
>
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henning Schmiedehausen updated SHINDIG-848:
-------------------------------------------

    Attachment: SHINDIG-848.patch

patch against trunk and 1.0.x-incubating

> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Features (Javascript)
>    Affects Versions: trunk, 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-848) core.io/io.js does not look at the return code from the request

Posted by "Vincent Siveton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton resolved SHINDIG-848.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0.x-incubating
                   trunk
         Assignee: Vincent Siveton

Applied in [r760873|http://svn.apache.org/viewvc?rev=760873&view=rev] Thanks!

> core.io/io.js does not look at the return code from the request
> ---------------------------------------------------------------
>
>                 Key: SHINDIG-848
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-848
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: trunk, 1.0.x-incubating
>            Reporter: Henning Schmiedehausen
>            Assignee: Vincent Siveton
>             Fix For: trunk, 1.0.x-incubating
>
>         Attachments: SHINDIG-848.patch
>
>
> While the backend return code is returned by the MakeRequestServlet (as rc element in the json object), it is never actually processed by the corresponding javascript. This patch fixes this and also lets nonProxiedRequest return an implicit 200 backend return code. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.