You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "tihom88 (via GitHub)" <gi...@apache.org> on 2023/04/14 04:59:50 UTC

[GitHub] [jackrabbit-oak] tihom88 commented on a diff in pull request #897: OAK-10187: oak-search-elastic: update Java Client independently of HLRC

tihom88 commented on code in PR #897:
URL: https://github.com/apache/jackrabbit-oak/pull/897#discussion_r1166278162


##########
oak-search-elastic/pom.xml:
##########
@@ -117,17 +118,17 @@
     <dependency>
       <groupId>org.elasticsearch.client</groupId>
       <artifactId>elasticsearch-rest-high-level-client</artifactId>
-      <version>${elasticsearch.version}</version>
+      <version>${elasticsearch.hlrc.version}</version>
     </dependency>
     <dependency>
       <groupId>org.elasticsearch.client</groupId>
       <artifactId>elasticsearch-rest-client</artifactId>
-      <version>${elasticsearch.version}</version>
+      <version>${elasticsearch.hlrc.version}</version>
     </dependency>
 	<dependency>
       <groupId>co.elastic.clients</groupId>
       <artifactId>elasticsearch-java</artifactId>
-      <version>${elasticsearch.version}</version>
+      <version>${elasticsearch.java.version}</version>

Review Comment:
   ```suggestion
         <version>${elasticsearch.java.client.version}</version>
   ```



##########
oak-search-elastic/pom.xml:
##########
@@ -33,7 +33,8 @@
   <description>Oak Elasticsearch integration subproject</description>
 
   <properties>
-    <elasticsearch.version>7.17.7</elasticsearch.version>
+    <elasticsearch.hlrc.version>7.17.9</elasticsearch.hlrc.version>
+    <elasticsearch.java.version>8.5.3</elasticsearch.java.version>

Review Comment:
   ```suggestion
       <elasticsearch.java.client.version>8.5.3</elasticsearch.java.client.version>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org