[jira] [Commented] (MESOS-86) Expose master url to the scheduler

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165791#comment-13165791 ] 

jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and John Sirois.


Summary
-------

    New Scheduler callbacks for master info (ip and port)
    
    --> registered() callback now includes maste info 
    --> new re-registered() callback is called when a new master is elected
    --> new masterLost() callback is called when mesos core doesnt detect an
    active master (e.g: during election)


This addresses bug MESOS-86.
    https://issues.apache.org/jira/browse/MESOS-86


Diffs
-----

  include/mesos/scheduler.hpp 93dda98 
  src/examples/cpp_test_framework.cpp ab02805 
  src/examples/java/TestExceptionFramework.java ba39757 
  src/examples/java/TestFramework.java e1b6032 
  src/examples/java/TestMultipleExecutorsFramework.java a49ecbb 
  src/examples/long_lived_framework.cpp 4003e47 
  src/examples/memhog.cpp 339d238 
  src/examples/python/test_framework.py e6893cf 
  src/examples/scheduled_memhog.cpp 5d01aef 
  src/java/jni/convert.cpp 04a25dd 
  src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663 
  src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
  src/master/master.cpp ede831e 
  src/messages/messages.proto a9cbcdc 
  src/python/native/proxy_scheduler.hpp a348cbb 
  src/python/native/proxy_scheduler.cpp 934820a 
  src/python/src/mesos.py 5fc60e2 
  src/sched/sched.cpp 7f4e980 
  src/tests/exception_tests.cpp 62f4fb6 
  src/tests/fault_tolerance_tests.cpp ebb7709 
  src/tests/master_tests.cpp a1f5007 
  src/tests/resource_offers_tests.cpp 8e1061e 
  src/tests/utils.hpp 65ce4df 

Diff: https://reviews.apache.org/r/3083/diff


Testing
-------

./bin/tests/all-tests


Thanks,

Vinod


                
> Expose master url to the scheduler
> ----------------------------------
>
>                 Key: MESOS-86
>                 URL: https://issues.apache.org/jira/browse/MESOS-86
>             Project: Mesos
>          Issue Type: New Feature
>            Reporter: Vinod Kone
>            Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would be useful for scheduler's to know this information (e.g: pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost()  that gets called whenever the current master loses election.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira