You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/01/14 06:11:54 UTC

[GitHub] [orc] zhanglistar commented on a change in pull request #1010: ORC-1090: Support compiling c++ using clang-13

zhanglistar commented on a change in pull request #1010:
URL: https://github.com/apache/orc/pull/1010#discussion_r784529026



##########
File path: cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -74,7 +74,7 @@ else ()
   set(SNAPPY_INCLUDE_DIR "${SNAPPY_HOME}/include")
   set(SNAPPY_STATIC_LIB "${SNAPPY_HOME}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}snappy${CMAKE_STATIC_LIBRARY_SUFFIX}")
   set(SNAPPY_CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${SNAPPY_HOME}
-                        -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib)
+                        -DBUILD_SHARED_LIBS=OFF -DCMAKE_INSTALL_LIBDIR=lib -DSNAPPY_BUILD_TESTS=OFF)

Review comment:
       > This looks like a regression. Why do we need this?
   
   Snappy compiles the unittest will have a link error not founding many symbols, so not to compile the ut.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org