You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2018/04/04 20:35:10 UTC
[GitHub] commons-text pull request #79: Upgrade to JUnit 5.1
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-text/pull/79
Upgrade to JUnit 5.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-text junit_5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-text/pull/79.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #79
----
commit f37a81c7bf965d593722d55ba1108c0c19b0fdb4
Author: Pascal Schumacher <pa...@...>
Date: 2018-04-04T20:33:48Z
Upgrade to JUnit 5.1
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/79
Comitted! :-) Works for me as well in Eclipse 4.7.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
JUnit 5 should work with any Eclipse Version released during the last year (as long as you delete existing run configurations for the project).
@garydgregory Can you give running this a try? I would like to merge it. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-text/pull/79

Screenshot with Eclipse version, and sample output (looks exactly like the output with JUnit 4).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
Great!
@kinow Thanks in-depth check!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text pull request #79: Upgrade to JUnit 5.1
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-text/pull/79
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by garydgregory <gi...@git.apache.org>.
Github user garydgregory commented on the issue:
https://github.com/apache/commons-text/pull/79
Hi Pascal! Thank you for the PR. My only hesitation with JUnit 5 is that it does not work in Eclipse yet, for me at least.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-text/pull/79
The only problem I encountered was that I had to delete the existing JUnit run configurations for commons-text (I'm using Eclipse Oxygen.3 and it does not seem to be able to update a run configuration from JUnit 4 to JUnit 5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by kinow <gi...@git.apache.org>.
Github user kinow commented on the issue:
https://github.com/apache/commons-text/pull/79
Tested the master branch first, and everything obviously worked. Then switched to this branch, and got an error message, then Eclipse opened the run configuration.
Followed @PascalSchumacher 's suggestion, removed the project JUnit run configurations, then re-run the class, and everything worked with no issues.
Tested a class, a method, and the entire project, by right clicking each of these, then Run As -> JUnit Test (i.e. Eclipse also recognized the files as JUnit tests).
Also put a breakpoint in some random method, then Debug As -> JUnit Test, and it worked as expected too.
Looks good to me. Might be a good idea to wait for @garydgregory 's feedback as I have very little experience with JUnit 5 for now, besides reading slides/docs/etc.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-text issue #79: Upgrade to JUnit 5.1
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-text/pull/79
[](https://coveralls.io/builds/16348620)
Coverage remained the same at 97.83% when pulling **f37a81c7bf965d593722d55ba1108c0c19b0fdb4 on PascalSchumacher:junit_5** into **6f06de9eb939599bb46a011a41764723953105ea on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org