You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/12/12 23:18:38 UTC

[GitHub] [helix] NealSun96 commented on a diff in pull request #2318: Fix rebalancer failure counter in async scenario

NealSun96 commented on code in PR #2318:
URL: https://github.com/apache/helix/pull/2318#discussion_r1046485817


##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java:
##########
@@ -460,6 +460,7 @@ private void globalRebalance(ResourceControllerDataProvider clusterData, Map<Str
           doGlobalRebalance(clusterData, resourceMap, algorithm, currentStateOutput, !waitForGlobalRebalance,
               clusterChanges);
         } catch (HelixRebalanceException e) {
+          _rebalanceFailureCount.increment(1L);

Review Comment:
   Yes, Global Rebalance failure was never accounted for in the failure metric. See #2062 . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org