[PR] `mempool` backtrace fix and de-init fix [nuttx]

["XuNeo (via GitHub)" <gi...@apache.org>]

XuNeo opened a new pull request, #14370:
URL: https://github.com/apache/nuttx/pull/14370

   *Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
   
   ## Summary
   
   Fix memory pool backtrace minor issues.
   1. Should use `backtrace_format` to format backtrace now.
   2. Default to turn of recording backtrace if `CONFIG_MM_BACKTRACE_DEFAULT ` is disabled. 
   
   Fix memory pool de-init. 
   Mark dict pointer as NULL after free, in case misuse of it.
   
   ## Impact
   
   *Update this section, where applicable, on how change affects users,
    build process, hardware, documentation, security, compatibility, etc.*
   
   Minor fixes, should have no impact.
   
   ## Testing
   
   *Update this section with details on how did you verify the change,
    what Host was used for build (OS, CPU, compiler, ..), what Target was
    used for verification (arch, board:config, ..), etc. Providing build
    and runtime logs from before and after change is highly appreciated.*
   
   CI build test pass.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] `mempool` backtrace fix and de-init fix [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #14370:
URL: https://github.com/apache/nuttx/pull/14370#issuecomment-2417003719

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   ## NuttX PR Requirements Review
   
   This PR appears to mostly meet the NuttX requirements, but could use some improvements in the "Testing" section. 
   
   **Here's a breakdown:**
   
   **✅ Summary:**
   
   * **Clear explanation of the changes:**  The summary clearly outlines the two main issues being addressed (memory pool backtrace and de-init) and provides a brief description of the solutions.
   * **Links to relevant issues:**  While the summary doesn't explicitly link to any specific issues, it's not strictly required if no directly related issues exist.
   
   **Could be improved 🤔 Impact:**
   
   * **Generic statement:** The impact section states "Minor fixes, should have no impact," which is too vague. 
   * **Be specific:**  Even if the impact is minimal, explicitly state which aspects are unaffected (e.g., "No impact on users, build process, or hardware support."). 
   * **Address potential changes:**  Mention if the backtrace changes could lead to different log outputs or require any configuration adjustments. 
   
   **Needs Improvement ❌  Testing:**
   
   * **Lack of details:** The testing section only mentions "CI build test pass," which is insufficient. 
   * **Provide specifics:**  Include:
       * Host OS, CPU architecture, compiler used for building.
       * Target architecture, board, and configuration tested on.
       * Ideally, provide snippets of the relevant log output before and after the change to demonstrate the fix. 
   
   **Recommendations:**
   
   1. **Expand the "Impact" section:** Provide specific details about the areas affected (or unaffected) by the changes.
   2. **Enhance the "Testing" section:**  Include concrete information about your testing environment (host and target) and demonstrate the fix's effectiveness with relevant log snippets.
   
   By addressing these points, you can make your PR even stronger and easier for reviewers to assess. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] `mempool` backtrace fix and de-init fix [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #14370:
URL: https://github.com/apache/nuttx/pull/14370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org