You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "James Strachan (JIRA)" <ji...@apache.org> on 2008/03/28 20:02:32 UTC

[jira] Created: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

working unit test required for HTTPS with the jetty component which works in maven
----------------------------------------------------------------------------------

                 Key: CAMEL-409
                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
             Project: Apache Camel
          Issue Type: Sub-task
            Reporter: James Strachan
            Assignee: Gary Tully




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment: camel-409.patch.plus

this patch superseeds the camel-409.patch file. 
It adds an additional negative test for camel http component calling https endpoint and expects an exception.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Gary Tully
>         Attachments: camel-409.patch, camel-409.patch.plus, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42227#action_42227 ] 

Claus Ibsen commented on CAMEL-409:
-----------------------------------

Gary could you provide a final patch with your and Mickys latest suggesting included.

I will then be able to commit the patch. It is a great addition to Camel.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.patch, camel-409.patch.plus, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Micky Santomax (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42205#action_42205 ] 

Micky Santomax commented on CAMEL-409:
--------------------------------------

Gary, I think is a good solution to set getter and setter methods for SslSocketConnector in JettyHttpComponent so that one can set (for example) the keystore path or anything else.

If you want to consider this suggestion I have attached file of jetty component with this patch implemented

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.patch, camel-409.patch.plus, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment: camel-409.combined.patch

adds sslsocketConnector accessor along with simple default sslPassword and sslKeyPassword that will solicit the default jetty behaviour of looking for jetty system properties or prompting the user.
If your config needs are simple, the accessors will work, if they are more complex, the ability to set the sslsocketconnector should be used. added another test that uses the sslsocketconnector accesor

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.combined.patch, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Micky Santomax (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Micky Santomax updated CAMEL-409:
---------------------------------

    Attachment: JettyHttpComponent.java

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.patch, camel-409.patch.plus, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment: camel-409.patch

jetty HttpsRouteTest - uses ssl attributes on JettyHttpComponent and system property for jsse client trust store configuration.
The keystore, localhost.ks is binary so it is not part of this patch.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Gary Tully
>         Attachments: camel-409.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment:     (was: camel-409.patch.plus)

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.combined.patch, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment: localhost.ks

components\camel-jetty\src\test\resources\jsse\localhost.ks a binary keystore file.

the contents of this file were created with:
keytool -genkey -alias server -keystore localhost.ks
using passwords: changeit and name components with value: localhost


The cert is used by the https endpoint and made available to the clients via their truststore so that the server cert can be validated. The cert is self signed. This is a dummy cert that is useful only for testing.
The use of localhost as the OU and CN allows the cert to pass spoofing validation as implemented by the jdk jsse implementation.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>            Reporter: James Strachan
>            Assignee: Gary Tully
>         Attachments: camel-409.patch, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-409:
------------------------------

        Fix Version/s: 1.4.0
    Affects Version/s: 1.3.0

Gary thanks a lot for all the hard work creating such a patch. We will definitely add it to Camel.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.patch, camel-409.patch.plus, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-409.
-------------------------------

    Resolution: Fixed

Comitted to trunk

CAMEL-409 Added unit tests for Jetty doing https. With huge thanks to Gary Tully and Micky Santomax for the patches

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.combined.patch, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated CAMEL-409:
-----------------------------

    Attachment:     (was: camel-409.patch)

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.combined.patch, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-409) working unit test required for HTTPS with the jetty component which works in maven

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42206#action_42206 ] 

Gary Tully commented on CAMEL-409:
----------------------------------

Micky, yea, that is a far better idea than replicating all of the Ssl attributes on JettyHttpComponent.
One thing to note is that in order for the jsse system properties to be picked up by the SssSocketConnector, a call to the setter methods is required, hense the default values of  "" for the key and keystore passwords in the JettyHttpComponent.
Without that we get the "no password" error. 
Best may be to lazily initialize the SslSocketConnector and call the setters if a user has not already provided an instance.

> working unit test required for HTTPS with the jetty component which works in maven
> ----------------------------------------------------------------------------------
>
>                 Key: CAMEL-409
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-409
>             Project: Apache Camel
>          Issue Type: Sub-task
>    Affects Versions: 1.3.0
>            Reporter: James Strachan
>            Assignee: Gary Tully
>             Fix For: 1.4.0
>
>         Attachments: camel-409.patch, camel-409.patch.plus, JettyHttpComponent.java, localhost.ks
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.