[GitHub] [camel] orpiske commented on a diff in pull request #9972: CAMEL-19295 - Concurrency issues with dynamicMap in AbstractDynamicRegistry

["orpiske (via GitHub)" <gi...@apache.org>]

orpiske commented on code in PR #9972:
URL: https://github.com/apache/camel/pull/9972#discussion_r1182688502


##########
core/camel-base-engine/src/main/java/org/apache/camel/impl/engine/AbstractDynamicRegistry.java:
##########
@@ -40,7 +39,7 @@
  * Base implementation for {@link org.apache.camel.spi.EndpointRegistry},
  * {@link org.apache.camel.spi.TransformerRegistry}, and {@link org.apache.camel.spi.ValidatorRegistry}.
  */
-public class AbstractDynamicRegistry<K, V> extends AbstractMap<K, V> implements StaticService {
+public class AbstractDynamicRegistry<K, V> extends ConcurrentHashMap<K, V> implements StaticService {

Review Comment:
   TBH, I kinda dislike the fact that it extends a core Java class. I wonder if we should, maybe, re-evaluate how we do this to avoid tightly coupling here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org