You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/04/23 18:54:04 UTC
Review Request 70532: Added UpdateFramework submessage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description (updated)
-------
Added the UpdateFramework submessage.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated May 17, 2019, 3 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Now the new call type is added to the switch statements in this patch.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
This patch definies the call to be used by a framework for updating its
FrameworkInfo fields without re-subscribing.
It is based on the previous implementation attempt:
https://reviews.apache.org/r/66228/
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp 35a04a3d0183697f93dadb3cbfead3ee0c2fea08
src/master/http.cpp c2c7b9b65bd66679420f62d37b01d90e3692c71d
src/master/master.cpp c72b92656dddca63ee89abf676da66bd76f58a6d
src/master/validation.cpp 9fb0850987ce385d345302cac9721adead7181b8
Diff: https://reviews.apache.org/r/70532/diff/6/
Changes: https://reviews.apache.org/r/70532/diff/5-6/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/#review215204
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On May 10, 2019, 3 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70532/
> -----------------------------------------------------------
>
> (Updated May 10, 2019, 3 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch definies the call to be used by a framework for updating its
> FrameworkInfo fields without re-subscribing.
>
> It is based on the previous implementation attempt:
> https://reviews.apache.org/r/66228/
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
> include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
>
>
> Diff: https://reviews.apache.org/r/70532/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated May 10, 2019, 3 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This patch definies the call to be used by a framework for updating its
FrameworkInfo fields without re-subscribing.
It is based on the previous implementation attempt:
https://reviews.apache.org/r/66228/
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/5/
Changes: https://reviews.apache.org/r/70532/diff/4-5/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated May 7, 2019, 1:06 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Added a brief description.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This patch definies the call to be used by a framework for updating its
FrameworkInfo fields without re-subscribing.
It is based on the previous implementation attempt:
https://reviews.apache.org/r/66228/
Diffs
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/4/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated May 2, 2019, 3:58 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fixed the comment describing UpdateFramework.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
Added an UPDATE_FRAMEWORK scheduler::Call.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/4/
Changes: https://reviews.apache.org/r/70532/diff/3-4/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 25, 2019, 8:37 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing.
It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe.
The previous attempt on which this review is based: https://reviews.apache.org/r/66228/
Diffs
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 25, 2019, 8:37 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing.
It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe.
The previous attempt on wich this review is based: https://reviews.apache.org/r/66228/
Diffs
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 25, 2019, 8:36 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing.
It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as Call::Subscribe.
The previous attempt on wich this review is based ://reviews.apache.org/r/66228/)?
Diffs
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 25, 2019, 8:12 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
Added an UPDATE_FRAMEWORK scheduler::Call.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/3/
Changes: https://reviews.apache.org/r/70532/diff/2-3/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 25, 2019, 8:01 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Fixed the comment describing the UpdateFramework call.
Summary (updated)
-----------------
Added an UPDATE_FRAMEWORK scheduler::Call.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description (updated)
-------
This review definies the UPDATE_FRAMEWORK call type for the frameworks to be able to update their FrameworkInfo fields without re-subscribing.
It also adds the corresponding `scheduler::Call:UpdateFramework` submessage with the same contents as `Call::Subscribe`.
Diffs (updated)
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/2/
Changes: https://reviews.apache.org/r/70532/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70532: Added UpdateFramework submessage.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/#review214865
-----------------------------------------------------------
How about: "Added an UPDATE_FRAMEWORK scheduler::Call."
Can you add a description and some context to the description (e.g. that it's based on https://reviews.apache.org/r/66228/)?
include/mesos/scheduler/scheduler.proto
Lines 492-493 (patched)
<https://reviews.apache.org/r/70532/#comment301136>
This will be the documentation for framework developers, so we should spell out separately and clearly which fields can't be mutated, e.g.:
```
// Updates the FrameworkInfo. All fields can be updated except
// the following:
//
// * FrameworkInfo.user
// * FrameworkInfo.checkpoint
//
// The possible responses are:
//
// * 200 OK: ...
// ...
```
include/mesos/scheduler/scheduler.proto
Lines 494 (patched)
<https://reviews.apache.org/r/70532/#comment301135>
newline before this list of responses
include/mesos/scheduler/scheduler.proto
Lines 497 (patched)
<https://reviews.apache.org/r/70532/#comment301134>
The next review says 403 and 409, but this one uses 401?
- Benjamin Mahler
On April 23, 2019, 7:04 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70532/
> -----------------------------------------------------------
>
> (Updated April 23, 2019, 7:04 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added the UpdateFramework submessage.
>
>
> Diffs
> -----
>
> include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
> include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
>
>
> Diff: https://reviews.apache.org/r/70532/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 70532: Added UpdateFramework submessage.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70532/
-----------------------------------------------------------
(Updated April 23, 2019, 7:04 p.m.)
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258
Repository: mesos
Description
-------
Added the UpdateFramework submessage.
Diffs
-----
include/mesos/scheduler/scheduler.proto b6d79b1c433dce77a6ee4278b3ddf6b69868c1d8
include/mesos/v1/scheduler/scheduler.proto bddd5c449fd4b294d15430746b708731aff18f2a
Diff: https://reviews.apache.org/r/70532/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko