You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "innerpeacez (via GitHub)" <gi...@apache.org> on 2023/03/07 04:42:59 UTC
[GitHub] [skywalking-kubernetes] innerpeacez opened a new pull request, #109: use pre chart hook
innerpeacez opened a new pull request, #109:
URL: https://github.com/apache/skywalking-kubernetes/pull/109
The init job should be executed first before oap start.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #109: The init job should be executed first before oap start.
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #109:
URL: https://github.com/apache/skywalking-kubernetes/pull/109#issuecomment-1457611611
I don't want oap to restart before initjob execution is completed, but after using startupProbe(https://github.com/apache/skywalking-kubernetes/pull/108), this phenomenon may be alleviated. If you feel that we don't need to manage dependencies, you can close this PR. @kezhenxu94 thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez closed pull request #109: The init job should be executed first before oap start.
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez closed pull request #109: The init job should be executed first before oap start.
URL: https://github.com/apache/skywalking-kubernetes/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 commented on pull request #109: The init job should be executed first before oap start.
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #109:
URL: https://github.com/apache/skywalking-kubernetes/pull/109#issuecomment-1457599376
> > This is wrong, init job requires some resources that must be applied first, using `pre-hook` the installation will be in dead lock state, `init-job` is waiting for other resources like service account, but service account resource is waiting for the `pre-hook` to complete
>
> hi, we have two ways to execute init-job 1: Let all resources that need to be started be executed with init-job first. 2: Start oap after init-job.
>
> The first way is relatively complicated, so I adopted the second way.
I don't personally want to use the helm hooks to manage the resource dependency, because in Kubernetes we don't need to manage the dependency too strictly, they will finally get in ready. The only reason why I introduced helm hook is to allow upgrading without having to delete all resource. See https://github.com/apache/skywalking-kubernetes/pull/95 and https://github.com/apache/skywalking/discussions/9290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] kezhenxu94 closed pull request #109: use pre chart hook
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 closed pull request #109: use pre chart hook
URL: https://github.com/apache/skywalking-kubernetes/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #109: The init job should be executed first before oap start.
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #109:
URL: https://github.com/apache/skywalking-kubernetes/pull/109#issuecomment-1457578567
> This is wrong, init job requires some resources that must be applied first, using `pre-hook` the installation will be in dead lock state, `init-job` is waiting for other resources like service account, but service account resource is waiting for the `pre-hook` to complete
hi, we have two ways to execute init-job
1: Let all resources that need to be started be executed with init-job first.
2: Start oap after init-job.
The first way is relatively complicated, so I adopted the second way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-kubernetes] innerpeacez commented on pull request #109: The init job should be executed first before oap start.
Posted by "innerpeacez (via GitHub)" <gi...@apache.org>.
innerpeacez commented on PR #109:
URL: https://github.com/apache/skywalking-kubernetes/pull/109#issuecomment-1467297064
Sorry. There are some problems with hook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org