You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/26 16:59:21 UTC
[GitHub] [lucene] uschindler opened a new issue, #11819: Fix Java 19 MR-JAR compilation in IDEs
uschindler opened a new issue, #11819:
URL: https://github.com/apache/lucene/issues/11819
### Description
After merge of #912 when creting the Eclipse workspace files, it also adds the Java 19 part, which fails to compile with JDK 11 or 17. I think the same will be happing with Intellij and others.
For exclipse we can exclude the source set, but this would mean you can't edit the source files with syntax highlighting and compilation checks (but you still see them). For me this would be fine, when I need to touch the Java 19 imple, I can read the source folder to build path, so maybe excluding is the best option. On the other hand, the failing compilation does not hur functionality of Eclipse. If you don't like it just right-click on the "core/java19" folder and select "Build path -> Remove from build path".
I have no idea about Intellij - @dweiss ?
What do other think? Just hide the source sets for Java 19 (and the ones for 20 and 21 coming later?).
### Version and environment details
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1259220386
I merged the Eclipse part. Robert yesterday tried to get hold of IDEA, but it looks like it is "mostly working" if you set the Java versions correctly (to 19). It looks like Idea picks per source folder the correct Java version, but it messed up compilation.
Of course, in both cases you need Java 19 added as IDE in Eclipse and IDEA if you want to edit the Java 19 features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1264782928
I have a solution for Intellij Idea: #11836
This variant disables compilation of the MR-JAR sourceSets (like in Eclipse).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] rmuir commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
Posted by GitBox <gi...@apache.org>.
rmuir commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1259352222
i tried wrestling with it, but i'm not sure i even held it properly. ultimately i was able to get it to work by setting entire project to java 19. this works for now, because "mr-jar" is not "really" used (there are no duplicate classes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] dweiss commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
Posted by GitBox <gi...@apache.org>.
dweiss commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1259684070
(away until the next of the week, guys - out of reach). bb on sunday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
Posted by GitBox <gi...@apache.org>.
uschindler commented on issue #11819:
URL: https://github.com/apache/lucene/issues/11819#issuecomment-1258639937
Here is the fix for Eclipse: #11823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org