[jira] [Updated] (GIRAPH-502) In PageRankBenchmark, remove unneeded handling of -t 2

["Eugene Koontz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GIRAPH-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Koontz updated GIRAPH-502:
---------------------------------

    Summary: In PageRankBenchmark, remove unneeded handling of -t 2  (was: In PageRankBenchmark, remove unused handling of -t 2)
    
> In PageRankBenchmark, remove unneeded handling of -t 2
> ------------------------------------------------------
>
>                 Key: GIRAPH-502
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-502
>             Project: Giraph
>          Issue Type: Improvement
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>            Priority: Minor
>
> PagerankBenchmark accepts, among other options, -t. For the usage message, it's treated as:
> t=0 (no combiner)
> t=1 (DoubleSumCombiner (default))
> However the code mentions a t=2, but this ends up being treated the same as t=0:
> {code}
> if (!cmd.hasOption('t') ||
>   (Integer.parseInt(cmd.getOptionValue('t')) == 2)) {
>      configuration.setVertexCombinerClass(
>           DoubleSumCombiner.class);
>     } else if (Integer.parseInt(cmd.getOptionValue('t')) == 1) {
>      configuration.setVertexCombinerClass(
>           DoubleSumCombiner.class);
>     }
> {code}
> We should make the code usage conform to the usage message and remove the extraneous -t=2 handling.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira