[jira] [Created] (HBASE-15064) Possbile Bug in MultiByteBuffer

["deepankar (JIRA)" <ji...@apache.org>]

deepankar created HBASE-15064:
---------------------------------

             Summary: Possbile Bug in MultiByteBuffer
                 Key: HBASE-15064
                 URL: https://issues.apache.org/jira/browse/HBASE-15064
             Project: HBase
          Issue Type: Bug
          Components: io
    Affects Versions: 2.0.0
            Reporter: deepankar
            Priority: Critical


While running the newer patches on our production system, I saw this error come couple of times 
{noformat}
ipc.RpcServer: Unexpected throwable object 
2016-01-01 16:42:56,090 ERROR [B.defaultRpcServer.handler=20,queue=20,port=60020] ipc.RpcServer: Unexpected throwable object 
java.nio.BufferUnderflowException
at java.nio.Buffer.nextGetIndex(Buffer.java:500)
at java.nio.DirectByteBuffer.get(DirectByteBuffer.java:249)
at org.apache.hadoop.hbase.nio.MultiByteBuff.get(MultiByteBuff.java:494)
at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decode(FastDiffDeltaEncoder.java:402) 
at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decodeNext(FastDiffDeltaEncoder.java:517) 
at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.next(BufferedDataBlockEncoder.java:815)
at org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:138)
{noformat}

Looking at the get code 
{code}
if (this.curItem.remaining() == 0) {
      if (items.length - 1 == this.curItemIndex) {
        // means cur item is the last one and we wont be able to read a long. Throw exception
        throw new BufferUnderflowException();
      }
      this.curItemIndex++;
      this.curItem = this.items[this.curItemIndex];
    }
return this.curItem.get();
{code}

Can the new currentItem have zero elements (position == limit), does it make sense to change the {{if}} to {{while}} ? {{while (this.curItem.remaining() == 0)}}. This logic is repeated may make sense abstract to a new function if we plan to change to  {{if}} to {{while}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)