[GitHub] [spark] szehon-ho commented on a diff in pull request #42324: [SPARK-44641][SQL] Incorrect result in certain scenarios when SPJ is not triggered

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #42324:
URL: https://github.com/apache/spark/pull/42324#discussion_r1284717091


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -355,6 +355,13 @@ case class KeyGroupedPartitioning(
 
   override def createShuffleSpec(distribution: ClusteredDistribution): ShuffleSpec =
     KeyGroupedShuffleSpec(this, distribution)
+
+  def uniquePartitionValues: Seq[InternalRow] = {

Review Comment:
   Actually one thought, would it make sense to make it lazy?  It seems only used in this one specific case when both flags are on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org