You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by br...@apache.org on 2013/10/15 23:23:01 UTC
svn commit: r1532539 - in
/hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response:
READDIR3Response.java READDIRPLUS3Response.java
Author: brandonli
Date: Tue Oct 15 21:23:00 2013
New Revision: 1532539
URL: http://svn.apache.org/r1532539
Log:
HDFS-5330. fix readdir and readdirplus for large directories. Contributed by Brandon Li
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIR3Response.java
hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIRPLUS3Response.java
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIR3Response.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIR3Response.java?rev=1532539&r1=1532538&r2=1532539&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIR3Response.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIR3Response.java Tue Oct 15 21:23:00 2013
@@ -26,6 +26,8 @@ import org.apache.hadoop.nfs.nfs3.Nfs3St
import org.apache.hadoop.oncrpc.XDR;
import org.apache.hadoop.oncrpc.security.Verifier;
+import com.google.common.annotations.VisibleForTesting;
+
/**
* READDIR3 Response
*/
@@ -49,7 +51,8 @@ public class READDIR3Response extends NF
return fileId;
}
- String getName() {
+ @VisibleForTesting
+ public String getName() {
return name;
}
@@ -66,6 +69,11 @@ public class READDIR3Response extends NF
this.entries = Collections.unmodifiableList(Arrays.asList(entries));
this.eof = eof;
}
+
+ @VisibleForTesting
+ public List<Entry3> getEntries() {
+ return this.entries;
+ }
}
public READDIR3Response(int status) {
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIRPLUS3Response.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIRPLUS3Response.java?rev=1532539&r1=1532538&r2=1532539&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIRPLUS3Response.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/READDIRPLUS3Response.java Tue Oct 15 21:23:00 2013
@@ -27,6 +27,8 @@ import org.apache.hadoop.nfs.nfs3.Nfs3St
import org.apache.hadoop.oncrpc.XDR;
import org.apache.hadoop.oncrpc.security.Verifier;
+import com.google.common.annotations.VisibleForTesting;
+
/**
* READDIRPLUS3 Response
*/
@@ -51,6 +53,11 @@ public class READDIRPLUS3Response exten
this.objFileHandle = objFileHandle;
}
+ @VisibleForTesting
+ public String getName() {
+ return name;
+ }
+
void seralize(XDR xdr) {
xdr.writeLongAsHyper(fileId);
xdr.writeString(name);
@@ -71,7 +78,8 @@ public class READDIRPLUS3Response exten
this.eof = eof;
}
- List<EntryPlus3> getEntries() {
+ @VisibleForTesting
+ public List<EntryPlus3> getEntries() {
return entries;
}
@@ -80,6 +88,11 @@ public class READDIRPLUS3Response exten
}
}
+ @VisibleForTesting
+ public DirListPlus3 getDirListPlus() {
+ return dirListPlus;
+ }
+
public READDIRPLUS3Response(int status) {
this(status, null, 0, null);
}