You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/13 03:45:50 UTC

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #19047: Add more unit test for DatabaseTypeFactory

terrymanu commented on code in PR #19047:
URL: https://github.com/apache/shardingsphere/pull/19047#discussion_r919621290


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/database/type/DatabaseTypeFactory.java:
##########
@@ -52,4 +59,41 @@ public static DatabaseType getInstance(final String name) {
     public static Collection<DatabaseType> getInstances() {
         return ShardingSphereServiceLoader.getServiceInstances(DatabaseType.class);
     }
+    

Review Comment:
   Why change main codes if the PR is add test cases only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org