You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "David Blevins (JIRA)" <ji...@apache.org> on 2010/04/01 13:40:27 UTC

[jira] Reopened: (OPENEJB-1252) Dont use URLDecoder on file paths, it doesn't work

     [ https://issues.apache.org/jira/browse/OPENEJB-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Blevins reopened OPENEJB-1252:
------------------------------------


We still need to do some decoding, just not the plus.  Windows will encode paths in jar URLs which has made this a hard problem to solve (see the tuscany-related https://issues.apache.org/jira/browse/OPENEJB-1068 which basically proposed the same solution you came up with).

I dug through harmony to see what they do to open streams to URLs in their file and jar url handlers.  Looks like the code does do the %hex decoding, but not + decoding.  Grabbing that code, cleaning it up, and will check that in shortly.

> Dont use URLDecoder on file paths, it doesn't work
> --------------------------------------------------
>
>                 Key: OPENEJB-1252
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1252
>             Project: OpenEJB
>          Issue Type: Bug
>    Affects Versions: 3.1.3
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 3.1.3
>
>
> URLS tries to use URLDecoder on a file path.  This converts the "+" characters mac os x likes to put in temp file names into " " (space) which causes disasters.  The javadoc says its not for paths, just form content encoded in a url.
> Use URI.create instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.