You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2014/10/04 04:16:20 UTC

logback in POMs

Hi All:

Shouldn't all the logback references in POMs be in the test scope?

Gary

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: logback in POMs

Posted by Matt Sicker <bo...@gmail.com>.
Remko, I fixed that in my local branch. I'll push that today before I
officially start the release process.

On 4 October 2014 07:47, Remko Popma <re...@gmail.com> wrote:

> The perf module doesn't have unit tests, all benchmarks are in main. Some
> benchmarks test logback, so that's ok to remain as a main dependency.
>
> Sent from my iPhone
>
> On 2014/10/04, at 21:18, Gary Gregory <ga...@gmail.com> wrote:
>
> Done. Just one change. The perf module is a "main" dep.
>
> Gary
>
> On Sat, Oct 4, 2014 at 1:11 AM, Matt Sicker <bo...@gmail.com> wrote:
>
>> That would make sense indeed.
>>
>> On 3 October 2014 21:16, Gary Gregory <ga...@gmail.com> wrote:
>>
>>> Hi All:
>>>
>>> Shouldn't all the logback references in POMs be in the test scope?
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> <http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> Matt Sicker <bo...@gmail.com>
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>


-- 
Matt Sicker <bo...@gmail.com>

Re: logback in POMs

Posted by Remko Popma <re...@gmail.com>.
The perf module doesn't have unit tests, all benchmarks are in main. Some benchmarks test logback, so that's ok to remain as a main dependency.  

Sent from my iPhone

> On 2014/10/04, at 21:18, Gary Gregory <ga...@gmail.com> wrote:
> 
> Done. Just one change. The perf module is a "main" dep.
> 
> Gary
> 
>> On Sat, Oct 4, 2014 at 1:11 AM, Matt Sicker <bo...@gmail.com> wrote:
>> That would make sense indeed.
>> 
>>> On 3 October 2014 21:16, Gary Gregory <ga...@gmail.com> wrote:
>>> Hi All:
>>> 
>>> Shouldn't all the logback references in POMs be in the test scope?
>>> 
>>> Gary
>>> 
>>> -- 
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com 
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>> 
>> 
>> 
>> -- 
>> Matt Sicker <bo...@gmail.com>
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Re: logback in POMs

Posted by Gary Gregory <ga...@gmail.com>.
Done. Just one change. The perf module is a "main" dep.

Gary

On Sat, Oct 4, 2014 at 1:11 AM, Matt Sicker <bo...@gmail.com> wrote:

> That would make sense indeed.
>
> On 3 October 2014 21:16, Gary Gregory <ga...@gmail.com> wrote:
>
>> Hi All:
>>
>> Shouldn't all the logback references in POMs be in the test scope?
>>
>> Gary
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <bo...@gmail.com>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: logback in POMs

Posted by Matt Sicker <bo...@gmail.com>.
That would make sense indeed.

On 3 October 2014 21:16, Gary Gregory <ga...@gmail.com> wrote:

> Hi All:
>
> Shouldn't all the logback references in POMs be in the test scope?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <bo...@gmail.com>