You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/14 16:24:56 UTC
[PR] Move DialectFunctionOption#getUnparenthesizedFunctionNames's default method to DefaultFunctionOption [shardingsphere]
terrymanu opened a new pull request, #39117:
URL: https://github.com/apache/shardingsphere/pull/39117
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move DialectFunctionOption#getUnparenthesizedFunctionNames's default method to DefaultFunctionOption [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39117:
URL: https://github.com/apache/shardingsphere/pull/39117#issuecomment-4971584685
### Summary
**Review Result: Mergeable**
Reason: The PR preserves the existing default behavior by moving the empty implementation to `DefaultFunctionOption`, while all in-repository dialect implementations provide their own method. This is a code-scope result only; CI was not reviewed by request.
### Evidence
- `DefaultFunctionOption` now returns the same empty collection previously supplied by the interface default method: `database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/option/function/DefaultFunctionOption.java:29-32`.
- `DialectFunctionOption` correctly becomes an explicit contract: `database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/metadata/option/function/DialectFunctionOption.java:32`.
- All ten in-repository implementations implement `getUnparenthesizedFunctionNames()`.
- Focused test passed: `DefaultFunctionOptionTest` — 1 test, 0 failures.
- Checkstyle passed for `database/connector/core`.
### Review Details
- Review Focus: Code Correctness Review; CI not reviewed by request.
- Reviewed Scope: Two PR files at head `cc137e304975272812cc92221557777334726c52`; local merge-base `955cb9123a21f093ecd8aecab5d8066d28cdc8d3`. Local file list matches GitHub `/pulls/39117/files`.
- Not Reviewed Scope: CI/check-run status and external downstream implementations.
- Verification: Focused Maven test exited 0; Checkstyle exited 0.
- Release Note / User Docs: Not required; this is an internal implementation refactor with no user-facing behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move DialectFunctionOption#getUnparenthesizedFunctionNames's default method to DefaultFunctionOption [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39117:
URL: https://github.com/apache/shardingsphere/pull/39117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org