[jira] [Resolved] (SPARK-15357) Cooperative spilling should check consumer memory mode

["Davies Liu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SPARK-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davies Liu resolved SPARK-15357.
--------------------------------
       Resolution: Fixed
    Fix Version/s: 2.0.0

Issue resolved by pull request 13151
[https://github.com/apache/spark/pull/13151]

> Cooperative spilling should check consumer memory mode
> ------------------------------------------------------
>
>                 Key: SPARK-15357
>                 URL: https://issues.apache.org/jira/browse/SPARK-15357
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 1.6.0
>            Reporter: Andrew Or
>            Assignee: Davies Liu
>             Fix For: 2.0.0
>
>
> In TaskMemoryManager.java:
> {code}
> for (MemoryConsumer c: consumers) {
>   if (c != consumer && c.getUsed() > 0) {
>     try {
>       long released = c.spill(required - got, consumer);
>         if (released > 0 && mode == tungstenMemoryMode) {
>           got += memoryManager.acquireExecutionMemory(required - got, taskAttemptId, mode);
>           if (got >= required) {
>             break;
>           }
>         }
>       } catch(...) { ... }
>     }
>   }
> }
> {code}
> Currently, when non-tungsten consumers acquire execution memory, they may force other tungsten consumers to spill and then NOT use the freed memory. A better way to do this is to incorporate the memory mode in the consumer itself and spill only those with matching memory modes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org