You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 15:57:17 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #10875: refactor: ASF only dependencies on base.txt
dpgaspar opened a new pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#issuecomment-692790933
> Sorry there’s a few things I don’t understand:
>
> 1. Why is `mysqlclient` not allowed in `base.txt` but is allowed in `setup.py`? Both files are included in the manifest as far as I’m aware.
> 2. I’m not sure why `integration.in` was incorporated into `development.in`. By definition this should contain the subset of packages required only to define the base integration environment for CI et al. and should be agnostic of Superset.
1 - `mysqlclient` is allowed on `setup.py` has an extra requirement, so our goal here is to make a Apache license compliant requirements file
2 - Yes that's a good point, I can re include `integration.in` has it was, and still have a `development.in` with all the necessary extras.
Extra question: Should we base `development.in` on `base.in` or branch it directly from `setup.py` to include the extras (like it's currently done on this PR) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r489060374
##########
File path: requirements/development.in
##########
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+-r base.in
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]
+flask-cors>=2.0.0
Review comment:
All I see in `development.txt` is `-e file:.`. The fact that you're explicitly enumerating these requirements in `development.in` should be more than suffice to generate the desired outcome in `development.txt`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#issuecomment-692447843
PR for fixing FOSSA license checks: https://github.com/apache/incubator-superset/pull/10848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488622476
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
Review comment:
Why is this needed? As development dependencies might be incompatible with the pinnings in `base.txt`, this might cause a clash.
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]
Review comment:
Should we add presto here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488368755
##########
File path: requirements/docker.txt
##########
@@ -9,6 +9,7 @@
-e file:. # via -r requirements/base.in
gevent==20.6.2 # via -r requirements/docker.in
greenlet==0.4.16 # via gevent
+psycopg2-binary==2.8.6 # via -r requirements/docker.in
Review comment:
This is only used to build Docker, which isn't actually pushed anywhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488351344
##########
File path: requirements/docker.txt
##########
@@ -9,6 +9,7 @@
-e file:. # via -r requirements/base.in
gevent==20.6.2 # via -r requirements/docker.in
greenlet==0.4.16 # via gevent
+psycopg2-binary==2.8.6 # via -r requirements/docker.in
Review comment:
My understanding is that the Docker build can't contain `psycopg2` due to licensing (sorry if this is premature).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r489070540
##########
File path: requirements/development.in
##########
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+-r base.in
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]
+flask-cors>=2.0.0
Review comment:
right, updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488690083
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
Review comment:
Updated but, like we already discussed this is debatable also:
Pros:
- Running `pip-compile-multi` to upgrade packages will just work. Currently we have to fix clashes manually.
Cons:
- `base.txt` and `development.txt` will slowly start to diverge. One could ask, whats the use for `base.txt`
- CI tests and docker will be based on `development.txt` and in time we will not guarantee these will be the same has the declared dependencies on `base.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#issuecomment-692796563
Ideally it should be based on `base.in` however I believe having multiple `-e file:.` in the dependency chain is problematic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] robdiciuccio commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488351344
##########
File path: requirements/docker.txt
##########
@@ -9,6 +9,7 @@
-e file:. # via -r requirements/base.in
gevent==20.6.2 # via -r requirements/docker.in
greenlet==0.4.16 # via gevent
+psycopg2-binary==2.8.6 # via -r requirements/docker.in
Review comment:
My understanding is that the Docker build can't contain `psycopg2` due to licensing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r489051262
##########
File path: requirements/development.in
##########
@@ -0,0 +1,27 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+-r base.in
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]
+flask-cors>=2.0.0
Review comment:
This is a bit of an hack to force `pip-compile-multi` to generate the necessary extra dependency locks. Since `-e file:.[cors,druid,hive,mysql,postgres,thumbnails]` was not being propagated to `development.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488686723
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
+-e file:.[cors,druid,hive,mysql,postgres,thumbnails]
Review comment:
debatable, because we are already using local dev docker based on development.txt and it already has lot's of "unnecessary" dependencies there
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10875: refactor: ASF only dependencies on base.txt
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10875:
URL: https://github.com/apache/incubator-superset/pull/10875#discussion_r488690083
##########
File path: requirements/development.in
##########
@@ -14,6 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
+-r base.txt
Review comment:
Updated but, like we already discussed this is debatable also:
Pros:
- Running `pip-compile-multi` to upgrade packages will just work. Currently we have to fix clashes manually.
Cons:
- `base.txt` and `development.txt` will slowly start to diverge. One could ask, whats the use for `base.txt`
- CI tests and docker will be based on `development.txt` and in time we will not guarantee these will be the same has the declared dependencies on `base.txt`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org