You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/08/23 22:10:40 UTC

[Impala-ASF-CR] IMPALA-5512: Distinguish GROUP BY and ORDER BY in SELECT syntax

John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7789

Change subject: IMPALA-5512: Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................

IMPALA-5512: Distinguish GROUP BY and ORDER BY in SELECT syntax

Turned one instance of GROUP BY in the syntax declaration
into ORDER BY. Moved NULLS FIRST and NULLS LAST from first
instance of GROUP BY to the new ORDER BY line.

Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
---
M docs/topics/impala_select.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/7789/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-docs-submit/150/

-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7789/2/docs/topics/impala_select.xml
File docs/topics/impala_select.xml:

Line 63: GROUP BY { <i>column</i> | <i>expression</i> [, ...] }
> ASC | DESC does not apply to GROUP BY
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Turned one instance of GROUP BY in the syntax declaration
into ORDER BY. Moved NULLS FIRST and NULLS LAST from first
instance of GROUP BY to the new ORDER BY line.

Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Reviewed-on: http://gerrit.cloudera.org:8080/7789
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_select.xml
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Alex Behm: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................

IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Turned one instance of GROUP BY in the syntax declaration
into ORDER BY. Moved NULLS FIRST and NULLS LAST from first
instance of GROUP BY to the new ORDER BY line.

Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
---
M docs/topics/impala_select.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/7789/3
-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


Patch Set 3: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................

IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Turned one instance of GROUP BY in the syntax declaration
into ORDER BY. Moved NULLS FIRST and NULLS LAST from first
instance of GROUP BY to the new ORDER BY line.

Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
---
M docs/topics/impala_select.xml
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/7789/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.

Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7789/2/docs/topics/impala_select.xml
File docs/topics/impala_select.xml:

Line 63: GROUP BY { <i>column</i> | <i>expression</i> [ASC | DESC] [, ...] }
ASC | DESC does not apply to GROUP BY


-- 
To view, visit http://gerrit.cloudera.org:8080/7789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df24cf5af4f2b0aabdb388b4e46a75e0e5275a7
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes