[GitHub] [incubator-yunikorn-web] yangwwei commented on a change in pull request #52: [YUNIKORN-606] Add a pull-request-template for web repo

[GitBox <gi...@apache.org>]

yangwwei commented on a change in pull request #52:
URL: https://github.com/apache/incubator-yunikorn-web/pull/52#discussion_r601619048



##########
File path: .github/PULL_REQUEST_TEMPLATE
##########
@@ -0,0 +1,24 @@
+### What is this PR for?
+A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-yunikorn-web/blob/master/docs/how-to-contribute.md   
+
+
+### What type of PR is it?
+[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

Review comment:
       Can we change this to a list of checkboxes?
   - [ ] Bug Fix
   - [ ] Improvement
   - [ ] Feature
   - [ ] Documentation
   - [ ] Refactoring

##########
File path: .github/PULL_REQUEST_TEMPLATE
##########
@@ -0,0 +1,24 @@
+### What is this PR for?
+A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-yunikorn-web/blob/master/docs/how-to-contribute.md   

Review comment:
       we should point this to the website doc: http://yunikorn.apache.org/community/how_to_contribute

##########
File path: .github/PULL_REQUEST_TEMPLATE
##########
@@ -0,0 +1,24 @@
+### What is this PR for?
+A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-yunikorn-web/blob/master/docs/how-to-contribute.md   
+
+
+### What type of PR is it?
+[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
+
+### Todos
+* [ ] - Task
+
+### What is the Jira issue?
+* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
+* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
+
+### How should this be tested?
+
+
+### Screenshots (if appropriate)
+
+### Questions:
+* Does the licenses files need update? Yes/No
+* Is there breaking changes for older versions? Yes/No
+* Does this needs documentation? Yes/No

Review comment:
       Suggest to change this to checkboxes as well:
   - [ ] Does the licenses files need update?
   - [ ] Is there breaking changes for older versions?
   - [ ] Does this needs documentation?

##########
File path: .github/PULL_REQUEST_TEMPLATE
##########
@@ -0,0 +1,24 @@
+### What is this PR for?
+A few sentences describing the overall goals of the pull request's commits.
+First time? Check out the contributing guide - https://github.com/apache/incubator-yunikorn-web/blob/master/docs/how-to-contribute.md   
+
+
+### What type of PR is it?
+[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
+
+### Todos
+* [ ] - Task
+
+### What is the Jira issue?
+* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
+* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
+
+### How should this be tested?

Review comment:
       Can we change this to "What tests have been done?"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org