You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2017/06/25 02:06:43 UTC

[21/47] lucene-solr:feature/autoscaling: remove SuppressPointFields from TestCloudPivotFacet

remove SuppressPointFields from TestCloudPivotFacet

now that SOLR-10864 is in place, there's no reason this test can't use points+docValues


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/ae011134
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/ae011134
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/ae011134

Branch: refs/heads/feature/autoscaling
Commit: ae01113472378093462e88b90e6e07a2cd863f8f
Parents: 9827648
Author: Chris Hostetter <ho...@apache.org>
Authored: Thu Jun 22 14:33:58 2017 -0700
Committer: Chris Hostetter <ho...@apache.org>
Committed: Thu Jun 22 14:33:58 2017 -0700

----------------------------------------------------------------------
 .../src/test/org/apache/solr/cloud/TestCloudPivotFacet.java   | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/ae011134/solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java b/solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java
index b13cb78..fb9c86a 100644
--- a/solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java
+++ b/solr/core/src/test/org/apache/solr/cloud/TestCloudPivotFacet.java
@@ -29,7 +29,6 @@ import java.util.Set;
 import org.apache.commons.lang.StringUtils;
 import org.apache.lucene.util.TestUtil;
 import org.apache.solr.SolrTestCaseJ4.SuppressSSL;
-import org.apache.solr.SolrTestCaseJ4.SuppressPointFields;
 import org.apache.solr.client.solrj.SolrServerException;
 import org.apache.solr.client.solrj.response.FieldStatsInfo;
 import org.apache.solr.client.solrj.response.PivotField;
@@ -79,7 +78,6 @@ import static org.apache.solr.common.params.FacetParams.FACET_DISTRIB_MCO;
  *
  */
 @SuppressSSL // Too Slow
-@SuppressPointFields
 public class TestCloudPivotFacet extends AbstractFullDistribZkTestBase {
 
   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
@@ -93,6 +91,11 @@ public class TestCloudPivotFacet extends AbstractFullDistribZkTestBase {
   // param used by test purely for tracing & validation
   private static String TRACE_SORT = "_test_sort";
 
+  public TestCloudPivotFacet() {
+    // we need DVs on point fields to compute stats & facets
+    if (Boolean.getBoolean(NUMERIC_POINTS_SYSPROP)) System.setProperty(NUMERIC_DOCVALUES_SYSPROP,"true");
+  }
+  
   /** 
    * Controls the odds of any given doc having a value in any given field -- as this gets lower, 
    * the counts for "facet.missing" pivots should increase.