You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "davidvoit (via GitHub)" <gi...@apache.org> on 2026/04/13 17:58:23 UTC
[PR] Also support non-byte type-annotations [qpid-jms]
davidvoit opened a new pull request, #61:
URL: https://github.com/apache/qpid-jms/pull/61
NMS AMQP is using "byte" which are unsigned in dotnet. Yes, this is non-std compatible, but not handling these values is also non-std compatible.
It's a MUST to sent data as signed byte.
But it's also a MUST to read other numeric values in the type-annotations fields in the binding spec.
This is related to https://github.com/apache/activemq-nms-amqp/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] [QPIDJMS-624] Also support non-byte type-annotations [qpid-jms]
Posted by "davidvoit (via GitHub)" <gi...@apache.org>.
davidvoit commented on code in PR #61:
URL: https://github.com/apache/qpid-jms/pull/61#discussion_r3361530507
##########
qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelperTest.java:
##########
@@ -688,6 +689,34 @@ public void testGetJmsReplToWithLegacyTempTopicTypeAnnotationNoConsumerDestinati
assertEquals(testAddress, destination.getAddress());
}
+ @Test
+ public void doGetJmsReplToWithTempQueueUnsignedByteTypeAnnotationTestImpl() throws Exception {
Review Comment:
Sorry this was copy paste error I think I copied another fragment before as a reference, this should hopefully be now fixed. If you have a better name just let me know :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] Also support non-byte type-annotations [qpid-jms]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on PR #61:
URL: https://github.com/apache/qpid-jms/pull/61#issuecomment-4606543829
A JIRA should be opened for this at https://issues.apache.org/jira/projects/QPIDJMS/ and the commit updated to reference the JIRA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] Also support non-byte type-annotations [qpid-jms]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 commented on code in PR #61:
URL: https://github.com/apache/qpid-jms/pull/61#discussion_r3344061961
##########
qpid-jms-client/src/test/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelperTest.java:
##########
@@ -688,6 +689,34 @@ public void testGetJmsReplToWithLegacyTempTopicTypeAnnotationNoConsumerDestinati
assertEquals(testAddress, destination.getAddress());
}
+ @Test
+ public void doGetJmsReplToWithTempQueueUnsignedByteTypeAnnotationTestImpl() throws Exception {
Review Comment:
The test names should be updated to follow the naming convention of the other tests in the test suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] [QPIDJMS-624] Also support non-byte type-annotations [qpid-jms]
Posted by "tabish121 (via GitHub)" <gi...@apache.org>.
tabish121 merged PR #61:
URL: https://github.com/apache/qpid-jms/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
Re: [PR] [QPIDJMS-624] Also support non-byte type-annotations [qpid-jms]
Posted by "davidvoit (via GitHub)" <gi...@apache.org>.
davidvoit commented on PR #61:
URL: https://github.com/apache/qpid-jms/pull/61#issuecomment-4722879437
@tabish121 do you need some other changes here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org