You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/13 23:33:37 UTC
[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()
Hello Kudu Jenkins, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15724
to review the following change.
Change subject: [common] update on HostPortFromPB()/HostPortToPB()
......................................................................
[common] update on HostPortFromPB()/HostPortToPB()
HostPortFromPB() and HostPortToPB() would never return non-OK status,
so it's possible to simplify the signature of these two methods.
This changelist doesn't contain any functional modifications.
Change-Id: I6dfcf747ee411f89c85e4c2d92ddbc756b551f43
Reviewed-on: http://gerrit.cloudera.org:8080/15713
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 8528ac70245efb6d7fec2d18dfa17e45b80421a9)
---
M src/kudu/client/client.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_replica_util.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
24 files changed, 53 insertions(+), 94 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15724/1
--
To view, visit http://gerrit.cloudera.org:8080/15724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dfcf747ee411f89c85e4c2d92ddbc756b551f43
Gerrit-Change-Number: 15724
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15724 )
Change subject: [common] update on HostPortFromPB()/HostPortToPB()
......................................................................
[common] update on HostPortFromPB()/HostPortToPB()
HostPortFromPB() and HostPortToPB() would never return non-OK status,
so it's possible to simplify the signature of these two methods.
This changelist doesn't contain any functional modifications.
Change-Id: I6dfcf747ee411f89c85e4c2d92ddbc756b551f43
Reviewed-on: http://gerrit.cloudera.org:8080/15713
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 8528ac70245efb6d7fec2d18dfa17e45b80421a9)
Reviewed-on: http://gerrit.cloudera.org:8080/15724
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus_meta-test.cc
M src/kudu/consensus/consensus_peers.cc
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/tablet_copy-itest.cc
M src/kudu/integration-tests/tablet_copy_client_session-itest.cc
M src/kudu/integration-tests/tombstoned_voting-stress-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/auto_rebalancer.cc
M src/kudu/master/master.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/master/ts_descriptor.cc
M src/kudu/mini-cluster/external_mini_cluster.cc
M src/kudu/server/server_base.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_local_replica.cc
M src/kudu/tools/tool_action_test.cc
M src/kudu/tools/tool_replica_util.cc
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/ts_tablet_manager.cc
24 files changed, 53 insertions(+), 94 deletions(-)
Approvals:
Kudu Jenkins: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I6dfcf747ee411f89c85e4c2d92ddbc756b551f43
Gerrit-Change-Number: 15724
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [common] update on HostPortFromPB()/HostPortToPB()
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15724 )
Change subject: [common] update on HostPortFromPB()/HostPortToPB()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15724
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dfcf747ee411f89c85e4c2d92ddbc756b551f43
Gerrit-Change-Number: 15724
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Apr 2020 05:33:59 +0000
Gerrit-HasComments: No